From: Tianchen Ding <dtcccc@linux.alibaba.com>
To: linux-kernel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf@vger.kernel.org
Subject: [PATCH v2] sched_ext: Use btf_ids to resolve task_struct
Date: Thu, 17 Oct 2024 10:44:12 +0800 [thread overview]
Message-ID: <20241017024412.16914-1-dtcccc@linux.alibaba.com> (raw)
Save the searching time during bpf_scx_init.
Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
---
v2:
Use the existing btf_tracing_ids[BTF_TRACING_TYPE_TASK].
v1: https://lore.kernel.org/all/20241016024100.7409-1-dtcccc@linux.alibaba.com/
---
kernel/sched/ext.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 609b9fb00d6f..09fe4e1552bb 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -5343,7 +5343,6 @@ static int scx_ops_enable(struct sched_ext_ops *ops, struct bpf_link *link)
extern struct btf *btf_vmlinux;
static const struct btf_type *task_struct_type;
-static u32 task_struct_type_id;
static bool set_arg_maybe_null(const char *op, int arg_n, int off, int size,
enum bpf_access_type type,
@@ -5395,7 +5394,7 @@ static bool set_arg_maybe_null(const char *op, int arg_n, int off, int size,
*/
info->reg_type = PTR_MAYBE_NULL | PTR_TO_BTF_ID | PTR_TRUSTED;
info->btf = btf_vmlinux;
- info->btf_id = task_struct_type_id;
+ info->btf_id = btf_tracing_ids[BTF_TRACING_TYPE_TASK];
return true;
}
@@ -5547,13 +5546,7 @@ static void bpf_scx_unreg(void *kdata, struct bpf_link *link)
static int bpf_scx_init(struct btf *btf)
{
- s32 type_id;
-
- type_id = btf_find_by_name_kind(btf, "task_struct", BTF_KIND_STRUCT);
- if (type_id < 0)
- return -EINVAL;
- task_struct_type = btf_type_by_id(btf, type_id);
- task_struct_type_id = type_id;
+ task_struct_type = btf_type_by_id(btf, btf_tracing_ids[BTF_TRACING_TYPE_TASK]);
return 0;
}
--
2.39.3
next reply other threads:[~2024-10-17 2:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 2:44 Tianchen Ding [this message]
2024-10-17 15:54 ` [PATCH v2] sched_ext: Use btf_ids to resolve task_struct Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017024412.16914-1-dtcccc@linux.alibaba.com \
--to=dtcccc@linux.alibaba.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox