From: Al Viro <viro@zeniv.linux.org.uk>
To: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, brauner@kernel.org,
jack@suse.cz, kpsingh@kernel.org, mattbobrowski@google.com,
amir73il@gmail.com, repnop@google.com, jlayton@kernel.org,
josef@toxicpanda.com
Subject: Re: [RFC bpf-next fanotify 2/5] samples/fanotify: Add a sample fanotify fastpath handler
Date: Wed, 30 Oct 2024 00:11:55 +0000 [thread overview]
Message-ID: <20241030001155.GF1350452@ZenIV> (raw)
In-Reply-To: <20241029231244.2834368-3-song@kernel.org>
On Tue, Oct 29, 2024 at 04:12:41PM -0700, Song Liu wrote:
> + if (strstr(file_name->name, item->prefix) == (char *)file_name->name)
Huh? "Find the first substring (if any) equal to item->prefix and
then check if that happens to be in the very beginning"???
And you are placing that into the place where it's most likely to cause
the maximal braindamage and spread all over the tree. Wonderful ;-/
Where does that "idiom" come from, anyway? Java? Not the first time
I see that kind of garbage; typecast is an unusual twist, though...
next prev parent reply other threads:[~2024-10-30 0:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 23:12 [RFC bpf-next fanotify 0/5] Fanotify fastpath handler Song Liu
2024-10-29 23:12 ` [RFC bpf-next fanotify 1/5] fanotify: Introduce fanotify " Song Liu
2024-10-30 12:45 ` Jeff Layton
2024-11-07 10:48 ` Jan Kara
2024-11-07 19:13 ` Song Liu
2024-11-11 14:09 ` Jan Kara
2024-10-29 23:12 ` [RFC bpf-next fanotify 2/5] samples/fanotify: Add a sample " Song Liu
2024-10-30 0:11 ` Al Viro [this message]
2024-10-30 1:48 ` Al Viro
2024-10-30 2:07 ` Song Liu
2024-10-30 2:35 ` Song Liu
2024-10-30 13:03 ` Jeff Layton
2024-10-30 20:30 ` Song Liu
2024-10-31 0:23 ` Jeff Layton
2024-10-31 1:52 ` Song Liu
2024-11-06 19:40 ` Amir Goldstein
2024-11-06 22:10 ` Song Liu
2024-11-07 10:41 ` Jan Kara
2024-11-07 19:39 ` Song Liu
2024-11-07 11:19 ` Amir Goldstein
2024-11-07 19:39 ` Song Liu
2024-10-29 23:12 ` [RFC bpf-next fanotify 3/5] bpf: Make bpf inode storage available to tracing programs Song Liu
2024-10-29 23:12 ` [RFC bpf-next fanotify 4/5] fanotify: Enable bpf based fanotify fastpath handler Song Liu
2024-10-29 23:12 ` [RFC bpf-next fanotify 5/5] selftests/bpf: Add test for BPF " Song Liu
2024-11-07 11:10 ` Amir Goldstein
2024-11-07 19:53 ` Song Liu
2024-11-07 20:33 ` Amir Goldstein
2024-11-07 20:48 ` Song Liu
2024-11-08 8:18 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030001155.GF1350452@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=repnop@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox