From: Leon Hwang <hffilwlqm@gmail.com>
To: bpf@vger.kernel.org
Cc: qmo@kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, leon.hwang@linux.dev,
kernel-patches-bot@fb.com
Subject: [PATCH bpf] bpf, bpftool: Fix incorrect disasm pc
Date: Wed, 30 Oct 2024 17:47:41 +0800 [thread overview]
Message-ID: <20241030094741.22929-1-hffilwlqm@gmail.com> (raw)
From: Leon Hwang <leon.hwang@linux.dev>
This patch addresses the bpftool issue "Wrong callq address displayed"[0].
The issue stemmed from an incorrect program counter (PC) value used during
disassembly with LLVM or libbfd. To calculate the correct address for
relative calls, the PC argument must reflect the actual address in the
kernel.
[0] https://github.com/libbpf/bpftool/issues/109
Fixes: e1947c750ffe ("bpftool: Refactor disassembler for JIT-ed programs")
Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
---
tools/bpf/bpftool/jit_disasm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index 7b8d9ec89ebd3..fe8fabba4b05f 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -114,8 +114,7 @@ disassemble_insn(disasm_ctx_t *ctx, unsigned char *image, ssize_t len, int pc)
char buf[256];
int count;
- count = LLVMDisasmInstruction(*ctx, image + pc, len - pc, pc,
- buf, sizeof(buf));
+ count = LLVMDisasmInstruction(*ctx, image, len, pc, buf, sizeof(buf));
if (json_output)
printf_json(buf);
else
@@ -360,7 +359,8 @@ int disasm_print_insn(unsigned char *image, ssize_t len, int opcodes,
printf("%4x:" DISASM_SPACER, pc);
}
- count = disassemble_insn(&ctx, image, len, pc);
+ count = disassemble_insn(&ctx, image + pc, len - pc,
+ func_ksym + pc);
if (json_output) {
/* Operand array, was started in fprintf_json. Before
--
2.44.0
next reply other threads:[~2024-10-30 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 9:47 Leon Hwang [this message]
2024-10-30 10:10 ` [PATCH bpf] bpf, bpftool: Fix incorrect disasm pc Leon Hwang
2024-10-30 14:56 ` Stanislav Fomichev
2024-10-30 15:13 ` Leon Hwang
2024-10-30 15:35 ` Stanislav Fomichev
2024-10-30 17:28 ` Yonghong Song
2024-10-31 0:27 ` Quentin Monnet
2024-10-31 5:27 ` Leon Hwang
2024-10-31 5:36 ` Leon Hwang
2024-10-31 14:58 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030094741.22929-1-hffilwlqm@gmail.com \
--to=hffilwlqm@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-patches-bot@fb.com \
--cc=leon.hwang@linux.dev \
--cc=qmo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox