BPF List
 help / color / mirror / Atom feed
From: Shigeru Yoshida <syoshida@redhat.com>
To: glider@google.com
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
	yonghong.song@linux.dev, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
	jolsa@kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	hawk@kernel.org, lorenzo@kernel.org, toke@redhat.com,
	bpf@vger.kernel.org, netdev@vger.kernel.org,
	syzkaller@googlegroups.com
Subject: Re: [PATCH bpf] bpf, test_run: Fix use-after-free issue in eth_skb_pkt_type()
Date: Mon, 02 Dec 2024 21:56:09 +0900 (JST)	[thread overview]
Message-ID: <20241202.215609.382397812745347709.syoshida@redhat.com> (raw)
In-Reply-To: <CAG_fn=VqUi=sGzz+0PJ9L7QrtOcgcn0ju=30BEGwB=D728wE8A@mail.gmail.com>

On Mon, 2 Dec 2024 10:32:04 +0100, Alexander Potapenko wrote:
> On Sun, Dec 1, 2024 at 4:27 PM Shigeru Yoshida <syoshida@redhat.com> wrote:
>>
>> KMSAN reported a use-after-free issue in eth_skb_pkt_type()[1]. The
>> cause of the issue was that eth_skb_pkt_type() accessed skb's data
>> that didn't contain an Ethernet header. This occurs when
>> bpf_prog_test_run_xdp() passes an invalid value as the user_data
>> argument to bpf_test_init().
> 
> Hi Shigeru,
> 
> Thanks for taking care of this!
> 
> Am I understanding right that this bug was reported by your own
> syzkaller instance?

Hi Alexander,

Thank you for your comment!

Yes, this issue was identified by running my own syzkaller locally.

I added the "Reported-by: syzkaller <syzkaller@googlegroups.com>" tag
to give credit to the syzkaller community.

> Otherwise, if the report originates from syzkaller.appspot.com, could
> you please append the bug hash to the Reported-by: tag?

I checked syzkaller.appspot.com, but this issue does not seem to be
reported.

Thanks,  
Shigeru

  reply	other threads:[~2024-12-02 12:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-01 15:27 [PATCH bpf] bpf, test_run: Fix use-after-free issue in eth_skb_pkt_type() Shigeru Yoshida
2024-12-02  9:32 ` Alexander Potapenko
2024-12-02 12:56   ` Shigeru Yoshida [this message]
2024-12-02 16:15 ` Stanislav Fomichev
2024-12-02 21:38   ` Martin KaFai Lau
2024-12-02 22:05     ` Martin KaFai Lau
2024-12-03  0:06     ` Stanislav Fomichev
2024-12-03 13:59       ` Shigeru Yoshida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202.215609.382397812745347709.syoshida@redhat.com \
    --to=syoshida@redhat.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=glider@google.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=syzkaller@googlegroups.com \
    --cc=toke@redhat.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox