BPF List
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, kkd@meta.com,
	Juri Lelli <juri.lelli@redhat.com>,
	Manu Bretelle <chantra@meta.com>, Jiri Olsa <jolsa@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	kernel-team@fb.com
Subject: Re: [PATCH bpf v1 3/4] bpf: Augment raw_tp arguments with PTR_MAYBE_NULL
Date: Thu, 12 Dec 2024 19:39:32 +0800	[thread overview]
Message-ID: <202412121921.xPnFS8u5-lkp@intel.com> (raw)
In-Reply-To: <20241211020156.18966-4-memxor@gmail.com>

Hi Kumar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 7d0d673627e20cfa3b21a829a896ce03b58a4f1c]

url:    https://github.com/intel-lab-lkp/linux/commits/Kumar-Kartikeya-Dwivedi/bpf-Revert-bpf-Mark-raw_tp-arguments-with-PTR_MAYBE_NULL/20241211-100358
base:   7d0d673627e20cfa3b21a829a896ce03b58a4f1c
patch link:    https://lore.kernel.org/r/20241211020156.18966-4-memxor%40gmail.com
patch subject: [PATCH bpf v1 3/4] bpf: Augment raw_tp arguments with PTR_MAYBE_NULL
config: i386-randconfig-062-20241212 (https://download.01.org/0day-ci/archive/20241212/202412121921.xPnFS8u5-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412121921.xPnFS8u5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412121921.xPnFS8u5-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/bpf/btf.c:6451:29: sparse: sparse: symbol 'raw_tp_null_args' was not declared. Should it be static?
   kernel/bpf/btf.c: note: in included file (through include/linux/bpf.h, include/linux/bpf_verifier.h):
   include/linux/bpfptr.h:65:40: sparse: sparse: cast to non-scalar
   include/linux/bpfptr.h:65:40: sparse: sparse: cast from non-scalar

vim +/raw_tp_null_args +6451 kernel/bpf/btf.c

  6450	
> 6451	struct bpf_raw_tp_null_args raw_tp_null_args[] = {
  6452		/* sched */
  6453		RAW_TP_NULL_ARGS(sched_pi_setprio, NULL_ARG(2)),
  6454		/* ... from sched_numa_pair_template event class */
  6455		RAW_TP_NULL_ARGS(sched_stick_numa, NULL_ARG(3)),
  6456		RAW_TP_NULL_ARGS(sched_swap_numa, NULL_ARG(3)),
  6457		/* afs */
  6458		RAW_TP_NULL_ARGS(afs_make_fs_call, NULL_ARG(2)),
  6459		RAW_TP_NULL_ARGS(afs_make_fs_calli, NULL_ARG(2)),
  6460		RAW_TP_NULL_ARGS(afs_make_fs_call1, NULL_ARG(2)),
  6461		RAW_TP_NULL_ARGS(afs_make_fs_call2, NULL_ARG(2)),
  6462		RAW_TP_NULL_ARGS(afs_protocol_error, NULL_ARG(1)),
  6463		RAW_TP_NULL_ARGS(afs_flock_ev, NULL_ARG(2)),
  6464		/* cachefiles */
  6465		RAW_TP_NULL_ARGS(cachefiles_lookup, NULL_ARG(1)),
  6466		RAW_TP_NULL_ARGS(cachefiles_unlink, NULL_ARG(1)),
  6467		RAW_TP_NULL_ARGS(cachefiles_rename, NULL_ARG(1)),
  6468		RAW_TP_NULL_ARGS(cachefiles_prep_read, NULL_ARG(1)),
  6469		RAW_TP_NULL_ARGS(cachefiles_mark_active, NULL_ARG(1)),
  6470		RAW_TP_NULL_ARGS(cachefiles_mark_failed, NULL_ARG(1)),
  6471		RAW_TP_NULL_ARGS(cachefiles_mark_inactive, NULL_ARG(1)),
  6472		RAW_TP_NULL_ARGS(cachefiles_vfs_error, NULL_ARG(1)),
  6473		RAW_TP_NULL_ARGS(cachefiles_io_error, NULL_ARG(1)),
  6474		RAW_TP_NULL_ARGS(cachefiles_ondemand_open, NULL_ARG(1)),
  6475		RAW_TP_NULL_ARGS(cachefiles_ondemand_copen, NULL_ARG(1)),
  6476		RAW_TP_NULL_ARGS(cachefiles_ondemand_close, NULL_ARG(1)),
  6477		RAW_TP_NULL_ARGS(cachefiles_ondemand_read, NULL_ARG(1)),
  6478		RAW_TP_NULL_ARGS(cachefiles_ondemand_cread, NULL_ARG(1)),
  6479		RAW_TP_NULL_ARGS(cachefiles_ondemand_fd_write, NULL_ARG(1)),
  6480		RAW_TP_NULL_ARGS(cachefiles_ondemand_fd_release, NULL_ARG(1)),
  6481		/* ext4, from ext4__mballoc event class */
  6482		RAW_TP_NULL_ARGS(ext4_mballoc_discard, NULL_ARG(2)),
  6483		RAW_TP_NULL_ARGS(ext4_mballoc_free, NULL_ARG(2)),
  6484		/* fib */
  6485		RAW_TP_NULL_ARGS(fib_table_lookup, NULL_ARG(3)),
  6486		/* filelock */
  6487		/* ... from filelock_lock event class */
  6488		RAW_TP_NULL_ARGS(posix_lock_inode, NULL_ARG(2)),
  6489		RAW_TP_NULL_ARGS(fcntl_setlk, NULL_ARG(2)),
  6490		RAW_TP_NULL_ARGS(locks_remove_posix, NULL_ARG(2)),
  6491		RAW_TP_NULL_ARGS(flock_lock_inode, NULL_ARG(2)),
  6492		/* ... from filelock_lease event class */
  6493		RAW_TP_NULL_ARGS(break_lease_noblock, NULL_ARG(2)),
  6494		RAW_TP_NULL_ARGS(break_lease_block, NULL_ARG(2)),
  6495		RAW_TP_NULL_ARGS(break_lease_unblock, NULL_ARG(2)),
  6496		RAW_TP_NULL_ARGS(generic_delete_lease, NULL_ARG(2)),
  6497		RAW_TP_NULL_ARGS(time_out_leases, NULL_ARG(2)),
  6498		/* host1x */
  6499		RAW_TP_NULL_ARGS(host1x_cdma_push_gather, NULL_ARG(5)),
  6500		/* huge_memory */
  6501		RAW_TP_NULL_ARGS(mm_khugepaged_scan_pmd, NULL_ARG(2)),
  6502		RAW_TP_NULL_ARGS(mm_collapse_huge_page_isolate, NULL_ARG(1)),
  6503		RAW_TP_NULL_ARGS(mm_khugepaged_scan_file, NULL_ARG(2)),
  6504		RAW_TP_NULL_ARGS(mm_khugepaged_collapse_file, NULL_ARG(2)),
  6505		/* kmem */
  6506		RAW_TP_NULL_ARGS(mm_page_alloc, NULL_ARG(1)),
  6507		RAW_TP_NULL_ARGS(mm_page_pcpu_drain, NULL_ARG(1)),
  6508		/* .. from mm_page event class */
  6509		RAW_TP_NULL_ARGS(mm_page_alloc_zone_locked, NULL_ARG(1)),
  6510		/* netfs */
  6511		RAW_TP_NULL_ARGS(netfs_failure, NULL_ARG(2)),
  6512		/* power */
  6513		RAW_TP_NULL_ARGS(device_pm_callback_start, NULL_ARG(2)),
  6514		/* qdisc */
  6515		RAW_TP_NULL_ARGS(qdisc_dequeue, NULL_ARG(4)),
  6516		/* rxrpc */
  6517		RAW_TP_NULL_ARGS(rxrpc_recvdata, NULL_ARG(1)),
  6518		RAW_TP_NULL_ARGS(rxrpc_resend, NULL_ARG(2)),
  6519		/* sunrpc */
  6520		RAW_TP_NULL_ARGS(xs_stream_read_data, NULL_ARG(1)),
  6521		/* tcp */
  6522		RAW_TP_NULL_ARGS(tcp_send_reset, NULL_ARG(1) | NULL_ARG(2)),
  6523		/* tegra_apb_dma */
  6524		RAW_TP_NULL_ARGS(tegra_dma_tx_status, NULL_ARG(3)),
  6525		/* timer_migration */
  6526		RAW_TP_NULL_ARGS(tmigr_update_events, NULL_ARG(1)),
  6527		/* writeback, from writeback_folio_template event class */
  6528		RAW_TP_NULL_ARGS(writeback_dirty_folio, NULL_ARG(2)),
  6529		RAW_TP_NULL_ARGS(folio_wait_writeback, NULL_ARG(2)),
  6530	};
  6531	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-12-12 11:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11  2:01 [PATCH bpf v1 0/4] Explicit raw_tp NULL arguments Kumar Kartikeya Dwivedi
2024-12-11  2:01 ` [PATCH bpf v1 1/4] bpf: Revert "bpf: Mark raw_tp arguments with PTR_MAYBE_NULL" Kumar Kartikeya Dwivedi
2024-12-11  2:01 ` [PATCH bpf v1 2/4] selftests/bpf: Revert "selftests/bpf: Add tests for raw_tp null handling" Kumar Kartikeya Dwivedi
2024-12-11  2:01 ` [PATCH bpf v1 3/4] bpf: Augment raw_tp arguments with PTR_MAYBE_NULL Kumar Kartikeya Dwivedi
2024-12-11 12:24   ` Jiri Olsa
2024-12-11 14:56   ` Jiri Olsa
2024-12-11 15:56   ` Alexei Starovoitov
2024-12-12 11:39   ` kernel test robot [this message]
2024-12-11  2:01 ` [PATCH bpf v1 4/4] selftests/bpf: Add autogenerated tests for raw_tp NULL args Kumar Kartikeya Dwivedi
2024-12-11 16:02   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202412121921.xPnFS8u5-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chantra@meta.com \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=kernel-team@fb.com \
    --cc=kkd@meta.com \
    --cc=martin.lau@kernel.org \
    --cc=memxor@gmail.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox