BPF List
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org, bpf <bpf@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>,
	Zheng Yejian <zhengyejian1@huawei.com>,
	Martin Kelly <martin.kelly@crowdstrike.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH 00/14] scripts/sorttable: ftrace: Remove place holders for weak functions in available_filter_functions
Date: Thu, 2 Jan 2025 16:44:54 -0500	[thread overview]
Message-ID: <20250102164454.2ffa33b1@gandalf.local.home> (raw)
In-Reply-To: <CAHk-=wjg4ckXG6tQHFAU_mL5vEFedwjGe=uahb31Oju50bYbNA@mail.gmail.com>

On Thu, 2 Jan 2025 11:30:12 -0800
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> Please just do this by sorting non-existent functions at the end,
> instead of just zeroing them out.
> 
> That makes the mcount_loc table dense in valid entries. We could then
> just rewrite the size of the table (or just add a variable containing
> the size, if you don't want to change ELF metadata - but you're
> already sorting the table, so why not?)

Well, I tried to move the __start_mcount_loc, but it appears that changing
the symbol value *after* the linking phase does nothing :-p  The references
to it have already been resolved. The Elf_Rel* will do the updates from
then on, and to read those, becomes architecture dependent.

I guess the next thing I could do is to create a "skip" variable that can
be modified, and we can skip X entries in the start_mcount_loc. As the
start_mcount_loc and stop_mcount_loc (which determines the size of the
table) cannot be modified in an architecture independent way.

-- Steve

  parent reply	other threads:[~2025-01-02 21:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 18:58 [PATCH 00/14] scripts/sorttable: ftrace: Remove place holders for weak functions in available_filter_functions Steven Rostedt
2025-01-02 18:58 ` [PATCH 01/14] scripts/sorttable: Remove unused macro defines Steven Rostedt
2025-01-02 18:58 ` [PATCH 02/14] scripts/sorttable: Remove unused write functions Steven Rostedt
2025-01-02 18:58 ` [PATCH 03/14] scripts/sorttable: Remove unneeded Elf_Rel Steven Rostedt
2025-01-02 18:58 ` [PATCH 04/14] scripts/sorttable: Have the ORC code use the _r() functions to read Steven Rostedt
2025-01-02 18:58 ` [PATCH 05/14] scripts/sorttable: Make compare_extable() into two functions Steven Rostedt
2025-01-02 18:58 ` [PATCH 06/14] scripts/sorttable: Convert Elf_Ehdr to union Steven Rostedt
2025-01-02 18:58 ` [PATCH 07/14] scripts/sorttable: Replace Elf_Shdr Macro with a union Steven Rostedt
2025-01-02 18:58 ` [PATCH 08/14] scripts/sorttable: Convert Elf_Sym MACRO over to " Steven Rostedt
2025-01-02 18:58 ` [PATCH 09/14] scripts/sorttable: Add helper functions for Elf_Ehdr Steven Rostedt
2025-01-02 18:58 ` [PATCH 10/14] scripts/sorttable: Add helper functions for Elf_Shdr Steven Rostedt
2025-01-02 18:58 ` [PATCH 11/14] scripts/sorttable: Add helper functions for Elf_Sym Steven Rostedt
2025-01-02 18:58 ` [PATCH 12/14] scripts/sorttable: Use uint64_t for mcount sorting Steven Rostedt
2025-01-02 18:58 ` [PATCH 13/14] scripts/sorttable: Move code from sorttable.h into sorttable.c Steven Rostedt
2025-01-02 18:58 ` [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak functions to available_filter_functions Steven Rostedt
2025-01-02 19:48   ` Peter Zijlstra
2025-01-02 19:55     ` Steven Rostedt
2025-01-02 20:03       ` Steven Rostedt
2025-01-02 20:32         ` Peter Zijlstra
2025-01-02 20:41           ` Steven Rostedt
2025-01-02 20:48             ` Peter Zijlstra
2025-01-02 20:53               ` Steven Rostedt
2025-01-02 20:24       ` Peter Zijlstra
2025-01-02 20:30         ` Steven Rostedt
2025-01-02 20:36           ` Peter Zijlstra
2025-01-02 20:45             ` Steven Rostedt
2025-01-03 11:10   ` Jiri Olsa
2025-01-03 11:41     ` Peter Zijlstra
2025-01-03 12:14       ` Steven Rostedt
2025-01-03 18:06         ` Jiri Olsa
2025-01-02 19:24 ` [PATCH 00/14] scripts/sorttable: ftrace: Remove place holders for weak functions in available_filter_functions Steven Rostedt
2025-01-02 19:30 ` Linus Torvalds
2025-01-02 19:45   ` Steven Rostedt
2025-01-02 19:47     ` Steven Rostedt
2025-01-02 21:44   ` Steven Rostedt [this message]
2025-01-02 22:14     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250102164454.2ffa33b1@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=bpf@vger.kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.kelly@crowdstrike.com \
    --cc=masahiroy@kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=zhengyejian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox