From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, bpf <bpf@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Zheng Yejian <zhengyejian1@huawei.com>,
Martin Kelly <martin.kelly@crowdstrike.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v2 13/16] scripts/sorttable: Move code from sorttable.h into sorttable.c
Date: Fri, 3 Jan 2025 18:02:43 -0500 [thread overview]
Message-ID: <20250103180243.53cc9e98@gandalf.local.home> (raw)
In-Reply-To: <20250102232650.834242633@goodmis.org>
On Thu, 02 Jan 2025 18:26:22 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> diff --git a/scripts/sorttable.c b/scripts/sorttable.c
> index 20615de18276..da9e1a82e886 100644
> --- a/scripts/sorttable.c
> +++ b/scripts/sorttable.c
> @@ -327,10 +327,420 @@ static inline void *get_index(void *start, int entsize, int index)
> return start + (entsize * index);
> }
>
> -/* 32 bit and 64 bit are very similar */
> -#include "sorttable.h"
> -#define SORTTABLE_64
> -#include "sorttable.h"
> +
[..]
> +
> +#if defined(SORTTABLE_64) && defined(UNWINDER_ORC_ENABLED)
My tests started to fail after this patch. It was the stack tracing tests
on x86_64. This patch removed the define of SORTTABLE_64, which stopped the
orc unwinder section from being sorted. :-p
Oops! When I post the stand-a-lone patches, this will be fixed.
-- Steve
> +/* ORC unwinder only support X86_64 */
> +#include <asm/orc_types.h>
> +
> +#define ERRSTR_MAXSZ 256
> +
next prev parent reply other threads:[~2025-01-03 23:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 23:26 [PATCH v2 00/16] scripts/sorttable: ftrace: Remove place holders for weak functions in available_filter_functions Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 01/16] scripts/sorttable: Remove unused macro defines Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 02/16] scripts/sorttable: Remove unused write functions Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 03/16] scripts/sorttable: Remove unneeded Elf_Rel Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 04/16] scripts/sorttable: Have the ORC code use the _r() functions to read Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 05/16] scripts/sorttable: Make compare_extable() into two functions Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 06/16] scripts/sorttable: Convert Elf_Ehdr to union Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 07/16] scripts/sorttable: Replace Elf_Shdr Macro with a union Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 08/16] scripts/sorttable: Convert Elf_Sym MACRO over to " Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 09/16] scripts/sorttable: Add helper functions for Elf_Ehdr Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 10/16] scripts/sorttable: Add helper functions for Elf_Shdr Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 11/16] scripts/sorttable: Add helper functions for Elf_Sym Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 12/16] scripts/sorttable: Use uint64_t for mcount sorting Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 13/16] scripts/sorttable: Move code from sorttable.h into sorttable.c Steven Rostedt
2025-01-03 23:02 ` Steven Rostedt [this message]
2025-01-02 23:26 ` [PATCH v2 14/16] scripts/sorttable: Get start/stop_mcount_loc from ELF file directly Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 15/16] scripts/sorttable: Zero out weak functions in mcount_loc table Steven Rostedt
2025-01-02 23:26 ` [PATCH v2 16/16] scripts/sorttable: ftrace: Do not add weak functions to available_filter_functions Steven Rostedt
2025-02-05 0:13 ` Martin Kelly
2025-02-05 0:35 ` Steven Rostedt
2025-02-05 16:00 ` Martin Kelly
2025-01-02 23:31 ` [PATCH v2 00/16] scripts/sorttable: ftrace: Remove place holders for weak functions in available_filter_functions Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103180243.53cc9e98@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.kelly@crowdstrike.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox