From: Daniel Borkmann <daniel@iogearbox.net>
To: kuba@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
Philo Lu <lulie@linux.alibaba.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: [PATCH net] netkit: Remove double invocation to clear ipvs property flag
Date: Tue, 25 Feb 2025 22:29:27 +0100 [thread overview]
Message-ID: <20250225212927.69271-1-daniel@iogearbox.net> (raw)
With ipvs_reset() now done unconditionally in skb_scrub_packet()
we would then call the former twice netkit_prep_forward(). Thus
remove the now unnecessary explicit call.
Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Philo Lu <lulie@linux.alibaba.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Martin KaFai Lau <martin.lau@kernel.org>
---
[ Sending to net since de2c211868b9 is in net ]
drivers/net/netkit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/netkit.c b/drivers/net/netkit.c
index 1e1b00756be7..20088f781376 100644
--- a/drivers/net/netkit.c
+++ b/drivers/net/netkit.c
@@ -65,7 +65,6 @@ static void netkit_prep_forward(struct sk_buff *skb,
skb_reset_mac_header(skb);
if (!xnet)
return;
- ipvs_reset(skb);
skb_clear_tstamp(skb);
if (xnet_scrub)
netkit_xnet(skb);
--
2.43.0
next reply other threads:[~2025-02-25 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 21:29 Daniel Borkmann [this message]
2025-02-26 9:48 ` [PATCH net] netkit: Remove double invocation to clear ipvs property flag Nikolay Aleksandrov
2025-02-27 1:33 ` Jakub Kicinski
2025-02-27 7:22 ` Daniel Borkmann
2025-02-28 1:29 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225212927.69271-1-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox