From: Eduard Zingerman <eddyz87@gmail.com>
To: bpf@vger.kernel.org, ast@kernel.org
Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
kernel-team@fb.com, yonghong.song@linux.dev,
Eduard Zingerman <eddyz87@gmail.com>,
Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Subject: [PATCH bpf-next v2 2/3] veristat: strerror expects positive number (errno)
Date: Fri, 28 Feb 2025 16:01:46 -0800 [thread overview]
Message-ID: <20250301000147.1583999-3-eddyz87@gmail.com> (raw)
In-Reply-To: <20250301000147.1583999-1-eddyz87@gmail.com>
Before:
./veristat -G @foobar iters.bpf.o
Failed to open presets in 'foobar': Unknown error -2
...
After:
./veristat -G @foobar iters.bpf.o
Failed to open presets in 'foobar': No such file or directory
...
Acked-by: Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
---
tools/testing/selftests/bpf/veristat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
index 8bc462299290..41dfcb6f5690 100644
--- a/tools/testing/selftests/bpf/veristat.c
+++ b/tools/testing/selftests/bpf/veristat.c
@@ -660,7 +660,7 @@ static int append_filter_file(const char *path)
f = fopen(path, "r");
if (!f) {
err = -errno;
- fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(err));
+ fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(-err));
return err;
}
@@ -1422,7 +1422,7 @@ static int append_var_preset_file(const char *filename)
f = fopen(filename, "rt");
if (!f) {
err = -errno;
- fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(err));
+ fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(-err));
return -EINVAL;
}
--
2.48.1
next prev parent reply other threads:[~2025-03-01 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 0:01 [PATCH bpf-next v2 0/3] veristat: @files-list.txt notation for object files list Eduard Zingerman
2025-03-01 0:01 ` [PATCH bpf-next v2 1/3] " Eduard Zingerman
2025-03-01 0:01 ` Eduard Zingerman [this message]
2025-03-01 0:01 ` [PATCH bpf-next v2 3/3] veristat: report program type guess results to sdterr Eduard Zingerman
2025-03-03 22:00 ` [PATCH bpf-next v2 0/3] veristat: @files-list.txt notation for object files list patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250301000147.1583999-3-eddyz87@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox