From: Emil Tsalapatis <emil@etsalapatis.com>
To: bpf@vger.kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
eddyz87@gmail.com, yonghong.song@linux.dev, tj@kernel.org,
memxor@gmail.com, houtao@huaweicloud.com,
Emil Tsalapatis <emil@etsalapatis.com>
Subject: [PATCH v7 4/4] selftests: bpf: fix duplicate selftests in cpumask_success.
Date: Sun, 9 Mar 2025 19:04:27 -0400 [thread overview]
Message-ID: <20250309230427.26603-5-emil@etsalapatis.com> (raw)
In-Reply-To: <20250309230427.26603-1-emil@etsalapatis.com>
The BPF cpumask selftests are currently run twice in
test_progs/cpumask.c, once by traversing cpumask_success_testcases, and
once by invoking RUN_TESTS(cpumask_success). Remove the invocation of
RUN_TESTS to properly run the selftests only once.
Now that the tests are run only through cpumask_success_testscases, add
to it the missing test_refcount_null_tracking testcase. Also remove the
__success annotation from it, since it is now loaded and invoked by the
runner.
Signed-off-by: Emil Tsalapatis (Meta) <emil@etsalapatis.com>
---
tools/testing/selftests/bpf/prog_tests/cpumask.c | 2 +-
tools/testing/selftests/bpf/progs/cpumask_success.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/cpumask.c b/tools/testing/selftests/bpf/prog_tests/cpumask.c
index 9b09beba988b..6c45330a5ca3 100644
--- a/tools/testing/selftests/bpf/prog_tests/cpumask.c
+++ b/tools/testing/selftests/bpf/prog_tests/cpumask.c
@@ -25,6 +25,7 @@ static const char * const cpumask_success_testcases[] = {
"test_global_mask_nested_deep_rcu",
"test_global_mask_nested_deep_array_rcu",
"test_cpumask_weight",
+ "test_refcount_null_tracking",
"test_populate_reject_small_mask",
"test_populate_reject_unaligned",
"test_populate",
@@ -81,6 +82,5 @@ void test_cpumask(void)
verify_success(cpumask_success_testcases[i]);
}
- RUN_TESTS(cpumask_success);
RUN_TESTS(cpumask_failure);
}
diff --git a/tools/testing/selftests/bpf/progs/cpumask_success.c b/tools/testing/selftests/bpf/progs/cpumask_success.c
index 91a5357769a8..0e04c31b91c0 100644
--- a/tools/testing/selftests/bpf/progs/cpumask_success.c
+++ b/tools/testing/selftests/bpf/progs/cpumask_success.c
@@ -749,7 +749,6 @@ int BPF_PROG(test_cpumask_weight, struct task_struct *task, u64 clone_flags)
}
SEC("tp_btf/task_newtask")
-__success
int BPF_PROG(test_refcount_null_tracking, struct task_struct *task, u64 clone_flags)
{
struct bpf_cpumask *mask1, *mask2;
--
2.47.1
next prev parent reply other threads:[~2025-03-09 23:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 23:04 [PATCH v7 0/4] bpf: introduce helper for populating bpf_cpumask Emil Tsalapatis
2025-03-09 23:04 ` [PATCH v7 1/4] bpf: add kfunc for populating cpumask bits Emil Tsalapatis
2025-03-09 23:04 ` [PATCH v7 2/4] selftests: bpf: add bpf_cpumask_populate selftests Emil Tsalapatis
2025-03-10 2:32 ` Hou Tao
2025-03-09 23:04 ` [PATCH v7 3/4] bpf: fix missing kdoc string fields in cpumask.c Emil Tsalapatis
2025-03-10 2:41 ` Hou Tao
2025-03-09 23:04 ` Emil Tsalapatis [this message]
2025-03-10 2:34 ` [PATCH v7 4/4] selftests: bpf: fix duplicate selftests in cpumask_success Hou Tao
2025-03-10 9:20 ` [PATCH v7 0/4] bpf: introduce helper for populating bpf_cpumask patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309230427.26603-5-emil@etsalapatis.com \
--to=emil@etsalapatis.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=houtao@huaweicloud.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox