From: Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
To: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kafai@meta.com, kernel-team@meta.com,
eddyz87@gmail.com, olsajiri@gmail.com, yonghong.song@linux.dev
Cc: Mykyta Yatsenko <yatsenko@meta.com>
Subject: [PATCH bpf-next v4 0/4] Support freplace prog from user namespace
Date: Mon, 10 Mar 2025 00:13:15 +0000 [thread overview]
Message-ID: <20250310001319.41393-1-mykyta.yatsenko5@gmail.com> (raw)
From: Mykyta Yatsenko <yatsenko@meta.com>
Freplace programs can't be loaded from user namespace, as
bpf_program__set_attach_target() requires searching for target prog BTF,
which is locked under CAP_SYS_ADMIN.
This patch set enables this use case by:
1. Relaxing capable check in bpf's BPF_BTF_GET_FD_BY_ID, check for CAP_BPF
instead of CAP_SYS_ADMIN, support BPF token in attr argument.
2. Pass BPF token around libbpf from bpf_program__set_attach_target() to
bpf syscall where capable check is.
3. Validate positive/negative scenarios in selftests
This patch set is enabled by the recent libbpf change[1], that
introduced bpf_object__prepare() API. Calling bpf_object__prepare() for
freplace program before bpf_program__set_attach_target() initializes BPF
token, which is then passed to bpf syscall by libbpf.
[1] https://lore.kernel.org/all/20250303135752.158343-1-mykyta.yatsenko5@gmail.com/
Mykyta Yatsenko (4):
bpf: BPF token support for BPF_BTF_GET_FD_BY_ID
bpf: return prog btf_id without capable check
libbpf: pass BPF token from find_prog_btf_id to BPF_BTF_GET_FD_BY_ID
selftests/bpf: test freplace from user namespace
include/uapi/linux/bpf.h | 1 +
kernel/bpf/syscall.c | 25 ++++-
tools/include/uapi/linux/bpf.h | 1 +
tools/lib/bpf/bpf.c | 3 +-
tools/lib/bpf/bpf.h | 4 +-
tools/lib/bpf/btf.c | 15 ++-
tools/lib/bpf/libbpf.c | 10 +-
tools/lib/bpf/libbpf_internal.h | 1 +
.../bpf/prog_tests/libbpf_get_fd_by_id_opts.c | 3 +-
.../testing/selftests/bpf/prog_tests/token.c | 97 ++++++++++++++++++-
.../selftests/bpf/progs/priv_freplace_prog.c | 13 +++
tools/testing/selftests/bpf/progs/priv_prog.c | 6 +-
12 files changed, 159 insertions(+), 20 deletions(-)
create mode 100644 tools/testing/selftests/bpf/progs/priv_freplace_prog.c
--
2.48.1
next reply other threads:[~2025-03-10 0:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 0:13 Mykyta Yatsenko [this message]
2025-03-10 0:13 ` [PATCH bpf-next v4 1/4] bpf: BPF token support for BPF_BTF_GET_FD_BY_ID Mykyta Yatsenko
2025-03-10 15:43 ` Yonghong Song
2025-03-10 15:57 ` Andrii Nakryiko
2025-03-10 18:29 ` Yonghong Song
2025-03-11 20:59 ` Mykyta Yatsenko
2025-03-12 18:50 ` Andrii Nakryiko
2025-03-10 0:13 ` [PATCH bpf-next v4 2/4] bpf: return prog btf_id without capable check Mykyta Yatsenko
2025-03-10 0:13 ` [PATCH bpf-next v4 3/4] libbpf: pass BPF token from find_prog_btf_id to BPF_BTF_GET_FD_BY_ID Mykyta Yatsenko
2025-03-10 16:00 ` Andrii Nakryiko
2025-03-10 0:13 ` [PATCH bpf-next v4 4/4] selftests/bpf: test freplace from user namespace Mykyta Yatsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310001319.41393-1-mykyta.yatsenko5@gmail.com \
--to=mykyta.yatsenko5@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kafai@meta.com \
--cc=kernel-team@meta.com \
--cc=olsajiri@gmail.com \
--cc=yatsenko@meta.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox