From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB6A225764; Tue, 11 Mar 2025 23:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741737185; cv=none; b=LMfXPNjRyS2AdYUKpkMavDjE/OppIOXSJukMCA6TDeSgw2ax9FyZRieSiU7b0/iLPTF9iCXITVzjojKimKeYXVN5aNiGVg6jl9cB2NAYgOewhG/gAaoL58AscZg51y4zXHwX3Xaxr4/AtuJ/OVs/t1QUrXSNX6CUt7WdwVFSIW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741737185; c=relaxed/simple; bh=ZDuIKhAOKv7u0D1U/ggHIkVzURa64HpNYfBlBsMwXlQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=g5vhMDoQl8I0PGJJx3JOTo8z3Ph1wS+c0uFXXCV5WpRxf2W9jketuMI76ulaVS1vJI6ukHjBXUDfXg8Fget0hiKD34hCiel7xOPLLOpT+339MroVYj+JbkYo/VHzKJfMRuU7ykku9H0nD35ShBbC3qVuglFSHHL3qKu1BzpRpmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=izHoZ4yA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="izHoZ4yA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15ECAC4CEE9; Tue, 11 Mar 2025 23:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741737184; bh=ZDuIKhAOKv7u0D1U/ggHIkVzURa64HpNYfBlBsMwXlQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=izHoZ4yA1A/BhXuUkOOUz5waOFa0sXQLSocZnkYUoDcXctHcRPvB9n5Qkq6FzyLnY nysVn9evKLogtFdTzEa2H9LN3DIa0l+z0bgrsjcCuwv49iEAcwWJ7N4APQim107ku6 Lc20pFn5ldtSaDzKcaKMSYkB/+2Zu1pcfZN98dhdEjfEwYZuYCu0GtVsCKLl/dGazd btLFuYa+awHnH+98ZYFLBuyqj/Hq3hbZDuLCjCH0U11ZLakOxGGFR+DlyIMEDVDU3J MgfNZfOQE9ASKA0mbK7SmwLsGIWA6zm4FmOdeb/+Id2gz1lNsSXmYARP2o11fRSR+x WRnwTz9nUGhYw== Date: Wed, 12 Mar 2025 08:52:53 +0900 From: Masami Hiramatsu (Google) To: Greg Kroah-Hartman Cc: Jiri Slaby , stable@vger.kernel.org, patches@lists.linux.dev, "Masami Hiramatsu (Google)" , Alexei Starovoitov , Florent Revest , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Heiko Carstens , Mark Rutland , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mathieu Desnoyers , Andrew Morton , "Steven Rostedt (Google)" , Sasha Levin Subject: Re: [PATCH 6.13 102/207] fprobe: Rewrite fprobe on function-graph tracer Message-Id: <20250312085253.99bef5db821c71b1bc4f3614@kernel.org> In-Reply-To: <2025031155-alabaster-sudoku-61c8@gregkh> References: <20250310170447.729440535@linuxfoundation.org> <20250310170451.816958751@linuxfoundation.org> <8ea06b5e-ec85-42e5-a2e9-9ad747fef217@kernel.org> <76c5a00f-ae15-43b8-a917-093ca63cc396@kernel.org> <2025031155-alabaster-sudoku-61c8@gregkh> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, 11 Mar 2025 15:12:13 +0100 Greg Kroah-Hartman wrote: > On Tue, Mar 11, 2025 at 10:56:26AM +0100, Jiri Slaby wrote: > > On 11. 03. 25, 10:49, Jiri Slaby wrote: > > > On 11. 03. 25, 10:46, Jiri Slaby wrote: > > > > On 10. 03. 25, 18:04, Greg Kroah-Hartman wrote: > > > > > 6.13-stable review patch.  If anyone has any objections, please > > > > > let me know. > > > > > > > > > > ------------------ > > > > > > > > > > From: Masami Hiramatsu (Google) > > > > > > > > > > [ Upstream commit 4346ba1604093305a287e08eb465a9c15ba05b80 ] > > > > ... > > > > > --- a/kernel/trace/Kconfig > > > > > +++ b/kernel/trace/Kconfig > > > > > @@ -302,11 +302,9 @@ config DYNAMIC_FTRACE_WITH_ARGS > > > > >   config FPROBE > > > > >       bool "Kernel Function Probe (fprobe)" > > > > > -    depends on FUNCTION_TRACER > > > > > -    depends on DYNAMIC_FTRACE_WITH_REGS || DYNAMIC_FTRACE_WITH_ARGS > > > > > -    depends on HAVE_FTRACE_REGS_HAVING_PT_REGS || ! > > > > > HAVE_DYNAMIC_FTRACE_WITH_ARGS > > > > > -    depends on HAVE_RETHOOK > > > > > -    select RETHOOK > > > > > +    depends on HAVE_FUNCTION_GRAPH_FREGS && HAVE_FTRACE_GRAPH_FUNC > > > > > > > > HAVE_FTRACE_GRAPH_FUNC does not exist on 6.13, so FPROBE is > > > > effectively disabled by this backport. > > > > > > > > Is this missing (and only this?): > > > > commit a762e9267dca843ced943ec24f20e110ba7c8431 > > > > Author: Masami Hiramatsu (Google) > > > > Date:   Thu Dec 26 14:13:34 2024 +0900 > > > > > > > >      ftrace: Add CONFIG_HAVE_FTRACE_GRAPH_FUNC > > > > > > With this applied, x86_64 is fixed. But ppc and s390 still loose it. > > > > > > HAVE_FTRACE_GRAPH_FUNC is missing in ppc completely in upstream too (a > > bug?). > > > > s390 has it only through (here omitted): > > commit 7495e179b478801433cec3cc4a82d2dcea35bf06 > > Author: Sven Schnelle > > Date: Thu Dec 26 14:13:48 2024 +0900 > > > > s390/tracing: Enable HAVE_FTRACE_GRAPH_FUNC > > Yeah, this isn't right. I've dropped all of these from the queue now, > thanks for the review! > Thanks Jiri and Greg! BTW, I wonder why this had been backported? I think this has no Fixes tag. maybe dependencies? Thank you, > greg k-h -- Masami Hiramatsu (Google)