From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Linxuan <chenlinxuan@deepin.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Sasha Levin <sashal@kernel.org>, Jann Horn <jannh@google.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
stable@vger.kernel.org, Eduard Zingerman <eddyz87@gmail.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH stable 6.6] lib/buildid: Handle memfd_secret() files in build_id_parse()
Date: Thu, 13 Mar 2025 17:04:54 +0100 [thread overview]
Message-ID: <2025031306-alumni-crinkly-5c0b@gregkh> (raw)
In-Reply-To: <CAC1kPDOXget0yMYPfQWbYPKrnSXL5RZ0f20Q8VmvT2zUTMBsNg@mail.gmail.com>
On Wed, Mar 12, 2025 at 11:03:18AM +0800, Chen Linxuan wrote:
> Greg KH <gregkh@linuxfoundation.org> 于2025年3月11日周二 19:14写道:
> >
> > On Tue, Mar 11, 2025 at 06:05:55PM +0800, Chen Linxuan wrote:
> > > Backport of a similar change from commit 5ac9b4e935df ("lib/buildid:
> > > Handle memfd_secret() files in build_id_parse()") to address an issue
> > > where accessing secret memfd contents through build_id_parse() would
> > > trigger faults.
> > >
> > > Original report and repro can be found in [0].
> > >
> > > [0] https://lore.kernel.org/bpf/ZwyG8Uro%2FSyTXAni@ly-workstation/
> > >
> > > This repro will cause BUG: unable to handle kernel paging request in
> > > build_id_parse in 5.15/6.1/6.6.
> > >
> > > Some other discussions can be found in [1].
> > >
> > > [1] https://lore.kernel.org/bpf/20241104175256.2327164-1-jolsa@kernel.org/T/#u
> > >
> > > Cc: stable@vger.kernel.org
> > > Fixes: 88a16a130933 ("perf: Add build id data in mmap2 event")
> > > Signed-off-by: Chen Linxuan <chenlinxuan@deepin.org>
> >
> > You dropped all the original signed-off-by and changelog text. Just
>
> The original commit is based on commit de3ec364c3c3 ("lib/buildid: add
> single folio-based file reader abstraction"). `git cherry-pick` result lots of
> conflicts. So I rewrite same logic on old code.
Then keep the original commit message, tell us what the original commit
id was, and then put in the signed-off-by area what you changed.
There's loads of examples of backports in this format on the stable
mailing list, look at them for what to do.
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-13 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:05 [PATCH stable 6.6] lib/buildid: Handle memfd_secret() files in build_id_parse() Chen Linxuan
2025-03-11 11:14 ` Greg KH
2025-03-12 3:03 ` Chen Linxuan
2025-03-12 18:43 ` Andrii Nakryiko
2025-03-13 16:04 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-14 6:40 Chen Linxuan
2025-03-16 6:13 ` Greg Kroah-Hartman
2025-03-14 9:03 Chen Linxuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025031306-alumni-crinkly-5c0b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adobriyan@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenlinxuan@deepin.org \
--cc=eddyz87@gmail.com \
--cc=jannh@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox