From: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Russell King <linux@armlinux.org.uk>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Furong Xu <0x1207@gmail.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Hariprasad Kelam <hkelam@marvell.com>,
Xiaolei Wang <xiaolei.wang@windriver.com>,
Suraj Jaiswal <quic_jsuraj@quicinc.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Gal Pressman <gal@nvidia.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
linux-stm32@st-md-mailman.stormreply.com,
Chwee-Lin Choong <chwee.lin.choong@intel.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Serge Semin <fancer.lancer@gmail.com>
Subject: [PATCH iwl-next v10 13/14] igc: add support to get MAC Merge data via ethtool
Date: Mon, 17 Mar 2025 23:07:41 -0400 [thread overview]
Message-ID: <20250318030742.2567080-14-faizal.abdul.rahim@linux.intel.com> (raw)
In-Reply-To: <20250318030742.2567080-1-faizal.abdul.rahim@linux.intel.com>
Implement "ethtool --show-mm" callback for IGC.
Tested with command:
$ ethtool --show-mm enp1s0.
MAC Merge layer state for enp1s0:
pMAC enabled: on
TX enabled: on
TX active: on
TX minimum fragment size: 64
RX minimum fragment size: 60
Verify enabled: on
Verify time: 128
Max verify time: 128
Verification status: SUCCEEDED
Verified that the fields value are retrieved correctly.
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 14 ++++++++++++++
drivers/net/ethernet/intel/igc/igc_tsn.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 529654ccd83f..fd4b4b332309 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1782,6 +1782,19 @@ static int igc_ethtool_set_eee(struct net_device *netdev,
return 0;
}
+static int igc_ethtool_get_mm(struct net_device *netdev,
+ struct ethtool_mm_state *cmd)
+{
+ struct igc_adapter *adapter = netdev_priv(netdev);
+ struct igc_fpe_t *fpe = &adapter->fpe;
+
+ ethtool_mmsv_get_mm(&fpe->mmsv, cmd);
+ cmd->tx_min_frag_size = fpe->tx_min_frag_size;
+ cmd->rx_min_frag_size = IGC_RX_MIN_FRAG_SIZE;
+
+ return 0;
+}
+
static int igc_ethtool_set_mm(struct net_device *netdev,
struct ethtool_mm_cfg *cmd,
struct netlink_ext_ack *extack)
@@ -2101,6 +2114,7 @@ static const struct ethtool_ops igc_ethtool_ops = {
.get_link_ksettings = igc_ethtool_get_link_ksettings,
.set_link_ksettings = igc_ethtool_set_link_ksettings,
.self_test = igc_ethtool_diag_test,
+ .get_mm = igc_ethtool_get_mm,
.set_mm = igc_ethtool_set_mm,
};
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.h b/drivers/net/ethernet/intel/igc/igc_tsn.h
index 58fe5f0773d7..c2a77229207b 100644
--- a/drivers/net/ethernet/intel/igc/igc_tsn.h
+++ b/drivers/net/ethernet/intel/igc/igc_tsn.h
@@ -4,6 +4,7 @@
#ifndef _IGC_TSN_H_
#define _IGC_TSN_H_
+#define IGC_RX_MIN_FRAG_SIZE 60
#define SMD_FRAME_SIZE 60
enum igc_txd_popts_type {
--
2.34.1
next prev parent reply other threads:[~2025-03-18 3:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 3:07 [PATCH iwl-next v10 00/14] igc: Add support for Frame Preemption feature in IGC Faizal Rahim
2025-03-18 3:07 ` [PATCH iwl-next v10 01/14] net: stmmac: move frag_size handling out of spin_lock Faizal Rahim
2025-03-18 3:07 ` [PATCH iwl-next v10 02/14] net: ethtool: mm: extract stmmac verification logic into common library Faizal Rahim
2025-03-18 3:07 ` [PATCH iwl-next v10 03/14] net: ethtool: mm: reset verification status when link is down Faizal Rahim
2025-03-18 3:07 ` [PATCH iwl-next v10 04/14] igc: rename xdp_get_tx_ring() for non-xdp usage Faizal Rahim
2025-03-27 12:55 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 05/14] igc: rename I225_RXPBSIZE_DEFAULT and I225_TXPBSIZE_DEFAULT Faizal Rahim
2025-03-27 12:56 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 06/14] igc: use FIELD_PREP and GENMASK for existing TX packet buffer size Faizal Rahim
2025-03-27 12:57 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 07/14] igc: optimize TX packet buffer utilization for TSN mode Faizal Rahim
2025-03-27 12:58 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 08/14] igc: use FIELD_PREP and GENMASK for existing RX packet buffer size Faizal Rahim
2025-03-27 12:59 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 09/14] igc: set the RX packet buffer size for TSN mode Faizal Rahim
2025-03-27 13:00 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 10/14] igc: add support for frame preemption verification Faizal Rahim
2025-03-27 13:02 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 11/14] igc: add support to set tx-min-frag-size Faizal Rahim
2025-03-27 13:03 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 12/14] igc: block setting preemptible traffic class in taprio Faizal Rahim
2025-03-27 13:03 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-03-18 3:07 ` Faizal Rahim [this message]
2025-03-27 13:04 ` [Intel-wired-lan] [PATCH iwl-next v10 13/14] igc: add support to get MAC Merge data via ethtool Mor Bar-Gabay
2025-03-18 3:07 ` [PATCH iwl-next v10 14/14] igc: add support to get frame preemption statistics " Faizal Rahim
2025-03-27 13:05 ` [Intel-wired-lan] " Mor Bar-Gabay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318030742.2567080-14-faizal.abdul.rahim@linux.intel.com \
--to=faizal.abdul.rahim@linux.intel.com \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chwee.lin.choong@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesper.nilsson@axis.com \
--cc=john.fastabend@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=quic_jsuraj@quicinc.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaolei.wang@windriver.com \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox