From: Sebastian Sewior <bigeasy@linutronix.de>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
bpf <bpf@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Michal Hocko <mhocko@suse.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Introduce try_alloc_pages for 6.15
Date: Mon, 31 Mar 2025 09:14:09 +0200 [thread overview]
Message-ID: <20250331071409.ycI7q6Q2@linutronix.de> (raw)
In-Reply-To: <CAADnVQKBg0ESvDRvs_cHHrwLrpkar9bAZ9JJRnxUwe4zfGym6w@mail.gmail.com>
On 2025-03-30 14:49:25 [-0700], Alexei Starovoitov wrote:
> On Sun, Mar 30, 2025 at 1:56 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > So maybe "nmisafe_local_lock_t" or something in that vein?
> >
> > Please fix this up, There aren't *that* many users of
> > "localtry_xyzzy", let's get this fixed before there are more of them.
>
> Ok. Agree with the reasoning that the name doesn't quite fit.
>
> nmisafe_local_lock_t name works for me,
> though nmisafe_local_lock_irqsave() is a bit verbose.
>
> Don't have better name suggestions at the moment.
>
> Sebastian, Vlastimil,
> what do you prefer ?
nmisafe_local_lock_t sounds okay assuming the "nmisafe" part does not
make it look like it can be used without the trylock part in NMI context.
But yeah, it sounds better than the previous one.
Sebastian
next prev parent reply other threads:[~2025-03-31 7:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 14:51 [GIT PULL] Introduce try_alloc_pages for 6.15 Alexei Starovoitov
2025-03-30 20:42 ` Linus Torvalds
2025-03-30 20:56 ` Linus Torvalds
2025-03-30 21:49 ` Alexei Starovoitov
2025-03-31 7:14 ` Sebastian Sewior [this message]
2025-03-31 9:59 ` Vlastimil Babka
2025-03-31 15:35 ` Linus Torvalds
2025-04-01 0:57 ` Alexei Starovoitov
2025-03-30 21:30 ` Alexei Starovoitov
2025-03-30 22:08 ` Linus Torvalds
2025-03-31 0:33 ` Alexei Starovoitov
2025-03-31 13:11 ` Vlastimil Babka
2025-03-31 14:59 ` Johannes Weiner
2025-03-30 21:05 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331071409.ycI7q6Q2@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.lau@kernel.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shakeel.butt@linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox