From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Aditya Gupta <adityag@linux.ibm.com>,
"Steinar H. Gunderson" <sesse@google.com>,
Charlie Jenkins <charlie@rivosinc.com>,
Changbin Du <changbin.du@huawei.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
James Clark <james.clark@linaro.org>,
Kajol Jain <kjain@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Li Huafei <lihuafei1@huawei.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andi Kleen <ak@linux.intel.com>,
Chaitanya S Prakash <chaitanyas.prakash@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
llvm@lists.linux.dev, Song Liu <song@kernel.org>,
bpf@vger.kernel.org
Subject: [PATCH v4 19/19] perf disasm: Remove unused evsel from annotate_args
Date: Thu, 17 Apr 2025 16:07:40 -0700 [thread overview]
Message-ID: <20250417230740.86048-20-irogers@google.com> (raw)
In-Reply-To: <20250417230740.86048-1-irogers@google.com>
Set in symbol__annotate but never used.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/annotate.c | 1 -
tools/perf/util/disasm.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 264a212b47df..a2a2849a5b79 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1013,7 +1013,6 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
struct symbol *sym = ms->sym;
struct annotation *notes = symbol__annotation(sym);
struct annotate_args args = {
- .evsel = evsel,
.options = &annotate_opts,
};
struct arch *arch = NULL;
diff --git a/tools/perf/util/disasm.h b/tools/perf/util/disasm.h
index 09c86f540f7f..d2cb555e4a3b 100644
--- a/tools/perf/util/disasm.h
+++ b/tools/perf/util/disasm.h
@@ -98,7 +98,6 @@ struct ins_ops {
struct annotate_args {
struct arch *arch;
struct map_symbol ms;
- struct evsel *evsel;
struct annotation_options *options;
s64 offset;
char *line;
--
2.49.0.805.g082f7c87e0-goog
next prev parent reply other threads:[~2025-04-17 23:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 23:07 [PATCH v4 00/19] Support dynamic opening of capstone/llvm remove BUILD_NONDISTRO Ian Rogers
2025-04-17 23:07 ` [PATCH v4 01/19] perf build: Remove libtracefs configuration Ian Rogers
2025-04-17 23:07 ` [PATCH v4 02/19] perf map: Constify objdump offset/address conversion APIs Ian Rogers
2025-04-17 23:07 ` [PATCH v4 03/19] perf capstone: Move capstone functionality into its own file Ian Rogers
2025-04-17 23:07 ` [PATCH v4 04/19] perf llvm: Move llvm " Ian Rogers
2025-04-17 23:07 ` [PATCH v4 05/19] perf capstone: Remove open_capstone_handle Ian Rogers
2025-04-17 23:07 ` [PATCH v4 06/19] perf capstone: Support for dlopen-ing libcapstone.so Ian Rogers
2025-06-26 23:19 ` Namhyung Kim
2025-06-27 4:53 ` Ian Rogers
2025-06-27 16:44 ` Ian Rogers
2025-06-27 19:26 ` Namhyung Kim
2025-06-27 23:11 ` Ian Rogers
2025-04-17 23:07 ` [PATCH v4 07/19] perf llvm: Support for dlopen-ing libLLVM.so Ian Rogers
2025-04-17 23:07 ` [PATCH v4 08/19] perf llvm: Mangle libperf-llvm.so function names Ian Rogers
2025-04-17 23:07 ` [PATCH v4 09/19] perf dso: Move read_symbol from llvm/capstone to dso Ian Rogers
2025-04-17 23:07 ` [PATCH v4 10/19] perf dso: Support BPF programs in dso__read_symbol Ian Rogers
2025-04-17 23:07 ` [PATCH v4 11/19] perf llvm: Disassemble cleanup Ian Rogers
2025-04-17 23:07 ` [PATCH v4 12/19] perf dso: Clean up read_symbol error handling Ian Rogers
2025-04-17 23:07 ` [PATCH v4 13/19] perf build: Remove libbfd support Ian Rogers
2025-04-17 23:07 ` [PATCH v4 14/19] perf build: Remove libiberty support Ian Rogers
2025-04-17 23:07 ` [PATCH v4 15/19] perf build: Remove unused defines Ian Rogers
2025-04-17 23:07 ` [PATCH v4 16/19] perf disasm: Remove disasm_bpf Ian Rogers
2025-04-17 23:07 ` [PATCH v4 17/19] perf disasm: Make ins__scnprintf and ins__is_nop static Ian Rogers
2025-04-17 23:07 ` [PATCH v4 18/19] perf srcline: Fallback between addr2line implementations Ian Rogers
2025-04-17 23:07 ` Ian Rogers [this message]
2025-04-18 21:29 ` [PATCH v4 00/19] Support dynamic opening of capstone/llvm remove BUILD_NONDISTRO Arnaldo Carvalho de Melo
2025-04-19 4:22 ` Ian Rogers
[not found] ` <CA+JHD93NCu5VeP9b+DzMm0f0YHwJLRFJeHNtWogx6wKFrHi8Yw@mail.gmail.com>
2025-05-27 20:45 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417230740.86048-20-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adityag@linux.ibm.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=chaitanyas.prakash@arm.com \
--cc=changbin.du@huawei.com \
--cc=charlie@rivosinc.com \
--cc=dvyukov@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=sesse@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox