bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, x86@kernel.org,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Hao Luo" <haoluo@google.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Alan Maguire" <alan.maguire@oracle.com>,
	"David Laight" <David.Laight@ACULAB.COM>,
	"Thomas Weißschuh" <thomas@t-8ch.de>,
	"Ingo Molnar" <mingo@kernel.org>
Subject: [PATCHv2 perf/core 13/22] selftests/bpf: Rename uprobe_syscall_executed prog to test_uretprobe_multi
Date: Thu, 15 May 2025 14:11:10 +0200	[thread overview]
Message-ID: <20250515121121.2332905-14-jolsa@kernel.org> (raw)
In-Reply-To: <20250515121121.2332905-1-jolsa@kernel.org>

Renaming uprobe_syscall_executed prog to test_uretprobe_multi
to fit properly in the following changes that add more programs.

Plus adding pid filter and increasing executed variable.

Acked-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 .../selftests/bpf/prog_tests/uprobe_syscall.c       | 12 ++++++++----
 .../selftests/bpf/progs/uprobe_syscall_executed.c   | 13 ++++++++++---
 2 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
index 2b00f16406c8..1cce50b5d18c 100644
--- a/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
+++ b/tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c
@@ -252,6 +252,7 @@ static void test_uretprobe_syscall_call(void)
 	);
 	struct uprobe_syscall_executed *skel;
 	int pid, status, err, go[2], c;
+	struct bpf_link *link;
 
 	if (!ASSERT_OK(pipe(go), "pipe"))
 		return;
@@ -277,11 +278,14 @@ static void test_uretprobe_syscall_call(void)
 		_exit(0);
 	}
 
-	skel->links.test = bpf_program__attach_uprobe_multi(skel->progs.test, pid,
-							    "/proc/self/exe",
-							    "uretprobe_syscall_call", &opts);
-	if (!ASSERT_OK_PTR(skel->links.test, "bpf_program__attach_uprobe_multi"))
+	skel->bss->pid = pid;
+
+	link = bpf_program__attach_uprobe_multi(skel->progs.test_uretprobe_multi,
+						pid, "/proc/self/exe",
+						"uretprobe_syscall_call", &opts);
+	if (!ASSERT_OK_PTR(link, "bpf_program__attach_uprobe_multi"))
 		goto cleanup;
+	skel->links.test_uretprobe_multi = link;
 
 	/* kick the child */
 	write(go[1], &c, 1);
diff --git a/tools/testing/selftests/bpf/progs/uprobe_syscall_executed.c b/tools/testing/selftests/bpf/progs/uprobe_syscall_executed.c
index 0d7f1a7db2e2..c4c3447378ba 100644
--- a/tools/testing/selftests/bpf/progs/uprobe_syscall_executed.c
+++ b/tools/testing/selftests/bpf/progs/uprobe_syscall_executed.c
@@ -8,10 +8,17 @@ struct pt_regs regs;
 char _license[] SEC("license") = "GPL";
 
 int executed = 0;
+int pid;
 
-SEC("uretprobe.multi")
-int test(struct pt_regs *regs)
+static int inc_executed(void)
 {
-	executed = 1;
+	if (bpf_get_current_pid_tgid() >> 32 == pid)
+		executed++;
 	return 0;
 }
+
+SEC("uretprobe.multi")
+int test_uretprobe_multi(struct pt_regs *ctx)
+{
+	return inc_executed();
+}
-- 
2.49.0


  parent reply	other threads:[~2025-05-15 12:14 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 12:10 [PATCHv2 perf/core 00/22] uprobes: Add support to optimize usdt probes on x86_64 Jiri Olsa
2025-05-15 12:10 ` [PATCHv2 perf/core 01/22] uprobes: Remove breakpoint in unapply_uprobe under mmap_write_lock Jiri Olsa
2025-05-19 23:48   ` Masami Hiramatsu
2025-05-20 14:16     ` Jiri Olsa
2025-05-20 14:19     ` Oleg Nesterov
2025-05-22 14:48       ` Masami Hiramatsu
2025-05-26 21:36         ` Jiri Olsa
2025-05-15 12:10 ` [PATCHv2 perf/core 02/22] uprobes: Rename arch_uretprobe_trampoline function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 03/22] uprobes: Make copy_from_page global Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 04/22] uprobes: Add uprobe_write function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 05/22] uprobes: Add nbytes argument to uprobe_write Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 06/22] uprobes: Add is_register argument to uprobe_write and uprobe_write_opcode Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 07/22] uprobes: Add do_ref_ctr argument to uprobe_write function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 08/22] uprobes/x86: Add mapping for optimized uprobe trampolines Jiri Olsa
2025-05-15 17:22   ` Andrii Nakryiko
2025-05-16  7:47     ` Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 09/22] uprobes/x86: Add uprobe syscall to speed up uprobe Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 10/22] uprobes/x86: Add support to optimize uprobes Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 11/22] selftests/bpf: Import usdt.h from libbpf/usdt project Jiri Olsa
2025-05-15 17:23   ` Andrii Nakryiko
2025-05-15 12:11 ` [PATCHv2 perf/core 12/22] selftests/bpf: Reorg the uprobe_syscall test function Jiri Olsa
2025-05-15 12:11 ` Jiri Olsa [this message]
2025-05-15 17:24   ` [PATCHv2 perf/core 13/22] selftests/bpf: Rename uprobe_syscall_executed prog to test_uretprobe_multi Andrii Nakryiko
2025-05-16  7:48     ` Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 14/22] selftests/bpf: Add uprobe/usdt syscall tests Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 15/22] selftests/bpf: Add hit/attach/detach race optimized uprobe test Jiri Olsa
2025-05-15 17:31   ` Andrii Nakryiko
2025-05-16  7:48     ` Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 16/22] selftests/bpf: Add uprobe syscall sigill signal test Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 17/22] selftests/bpf: Add optimized usdt variant for basic usdt test Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 18/22] selftests/bpf: Add uprobe_regs_equal test Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 19/22] selftests/bpf: Change test_uretprobe_regs_change for uprobe and uretprobe Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 20/22] seccomp: passthrough uprobe systemcall without filtering Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 21/22] selftests/seccomp: validate uprobe syscall passes through seccomp Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 22/22] man2: Add uprobe syscall page Jiri Olsa
2025-05-15 22:08   ` Alejandro Colomar
2025-05-30 15:35 ` [PATCHv2 perf/core 00/22] uprobes: Add support to optimize usdt probes on x86_64 Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250515121121.2332905-14-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=David.Laight@ACULAB.COM \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=songliubraving@fb.com \
    --cc=thomas@t-8ch.de \
    --cc=x86@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).