From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Alejandro Colomar" <alx@kernel.org>,
"Eyal Birger" <eyal.birger@gmail.com>,
kees@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
x86@kernel.org, "Song Liu" <songliubraving@fb.com>,
"Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Hao Luo" <haoluo@google.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Alan Maguire" <alan.maguire@oracle.com>,
"David Laight" <David.Laight@ACULAB.COM>,
"Thomas Weißschuh" <thomas@t-8ch.de>,
"Ingo Molnar" <mingo@kernel.org>
Subject: Re: [PATCHv2 perf/core 00/22] uprobes: Add support to optimize usdt probes on x86_64
Date: Fri, 30 May 2025 17:35:16 +0200 [thread overview]
Message-ID: <20250530153516.GA25160@redhat.com> (raw)
In-Reply-To: <20250515121121.2332905-1-jolsa@kernel.org>
On 05/15, Jiri Olsa wrote:
>
> Changes from v1:
> - rebased on top of tip/master + mm/mm-stable + 1 extra change [1]
> - keep the refcrf offset update inside write_insn and enabling it
> via function argument
> - fixed locking comment for uprobe_write_opcode, but skiped suggested
> comment on register_for_each_vma, need more thinking on that [Oleg]
> - added acks
> - removed refctr from uprobe_trampoline object [Oleg]
> - change find_nearest_page to use vm_unmapped_area [Oleg]
> - re-structured x86 set_swbp [Andrii]
> - use -EINVAL in __arch_uprobe_optimize [Andrii]
> - added usdt.h from libbpf/usdt project [Andrii]
> - several minor test code changes [Andrii]
> - man page updates [Alejandro]
I forgot to send this email a week ago, sorry...
This version seems to address my concerns. I don't see anything obviously
wrong. So if this optimization is important for users... FWIW,
For 1/22 - 10/22
Acked-by: Oleg Nesterov <oleg@redhat.com>
prev parent reply other threads:[~2025-05-30 15:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:10 [PATCHv2 perf/core 00/22] uprobes: Add support to optimize usdt probes on x86_64 Jiri Olsa
2025-05-15 12:10 ` [PATCHv2 perf/core 01/22] uprobes: Remove breakpoint in unapply_uprobe under mmap_write_lock Jiri Olsa
2025-05-19 23:48 ` Masami Hiramatsu
2025-05-20 14:16 ` Jiri Olsa
2025-05-20 14:19 ` Oleg Nesterov
2025-05-22 14:48 ` Masami Hiramatsu
2025-05-26 21:36 ` Jiri Olsa
2025-05-15 12:10 ` [PATCHv2 perf/core 02/22] uprobes: Rename arch_uretprobe_trampoline function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 03/22] uprobes: Make copy_from_page global Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 04/22] uprobes: Add uprobe_write function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 05/22] uprobes: Add nbytes argument to uprobe_write Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 06/22] uprobes: Add is_register argument to uprobe_write and uprobe_write_opcode Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 07/22] uprobes: Add do_ref_ctr argument to uprobe_write function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 08/22] uprobes/x86: Add mapping for optimized uprobe trampolines Jiri Olsa
2025-05-15 17:22 ` Andrii Nakryiko
2025-05-16 7:47 ` Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 09/22] uprobes/x86: Add uprobe syscall to speed up uprobe Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 10/22] uprobes/x86: Add support to optimize uprobes Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 11/22] selftests/bpf: Import usdt.h from libbpf/usdt project Jiri Olsa
2025-05-15 17:23 ` Andrii Nakryiko
2025-05-15 12:11 ` [PATCHv2 perf/core 12/22] selftests/bpf: Reorg the uprobe_syscall test function Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 13/22] selftests/bpf: Rename uprobe_syscall_executed prog to test_uretprobe_multi Jiri Olsa
2025-05-15 17:24 ` Andrii Nakryiko
2025-05-16 7:48 ` Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 14/22] selftests/bpf: Add uprobe/usdt syscall tests Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 15/22] selftests/bpf: Add hit/attach/detach race optimized uprobe test Jiri Olsa
2025-05-15 17:31 ` Andrii Nakryiko
2025-05-16 7:48 ` Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 16/22] selftests/bpf: Add uprobe syscall sigill signal test Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 17/22] selftests/bpf: Add optimized usdt variant for basic usdt test Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 18/22] selftests/bpf: Add uprobe_regs_equal test Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 19/22] selftests/bpf: Change test_uretprobe_regs_change for uprobe and uretprobe Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 20/22] seccomp: passthrough uprobe systemcall without filtering Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 perf/core 21/22] selftests/seccomp: validate uprobe syscall passes through seccomp Jiri Olsa
2025-05-15 12:11 ` [PATCHv2 22/22] man2: Add uprobe syscall page Jiri Olsa
2025-05-15 22:08 ` Alejandro Colomar
2025-05-30 15:35 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250530153516.GA25160@redhat.com \
--to=oleg@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=alan.maguire@oracle.com \
--cc=alx@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eyal.birger@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=thomas@t-8ch.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).