From: Jakub Kicinski <kuba@kernel.org>
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check
Date: Wed, 18 Jun 2025 19:11:11 -0700 [thread overview]
Message-ID: <20250618191111.29e6136e@kernel.org> (raw)
In-Reply-To: <20250615151333.10644-2-minhquangbui99@gmail.com>
On Sun, 15 Jun 2025 22:13:32 +0700 Bui Quang Minh wrote:
> +/**
> + * buf_to_xdp() - convert the @buf context to xdp_buff
> + * @vi: virtnet_info struct
> + * @rq: the receive queue struct
> + * @buf: the xdp_buff pointer that is passed to virtqueue_add_inbuf_premapped in
> + * virtnet_add_recvbuf_xsk
> + * @len: the length of received data without virtio header's length
> + * @first_buf: this buffer is the first one or not
> + */
> static struct xdp_buff *buf_to_xdp(struct virtnet_info *vi,
> - struct receive_queue *rq, void *buf, u32 len)
> + struct receive_queue *rq, void *buf,
> + u32 len, bool first_buf)
I think Michael mention he's AFK so while we wait could you fix this
kdoc? I'm not sure whether the kdoc is really necessary here, but if
you want to keep it you have to document the return value:
Warning: drivers/net/virtio_net.c:1141 No description found for return value of 'buf_to_xdp'
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-19 2:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 15:13 [PATCH net 0/2] virtio-net: xsk: rx: fix the frame's length check Bui Quang Minh
2025-06-15 15:13 ` [PATCH net 1/2] " Bui Quang Minh
2025-06-19 2:11 ` Jakub Kicinski [this message]
2025-06-19 14:17 ` Bui Quang Minh
2025-06-19 15:26 ` Jakub Kicinski
2025-06-15 15:13 ` [PATCH net 2/2] virtio-net: xsk: rx: move the xdp->data adjustment to buf_to_xdp() Bui Quang Minh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618191111.29e6136e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minhquangbui99@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).