bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Christoph Hellwig" <hch@lst.de>,
	Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next 2/2] umd: Remove usermode driver framework
Date: Tue, 22 Jul 2025 08:33:28 +0200	[thread overview]
Message-ID: <20250722063328.GA15403@lst.de> (raw)
In-Reply-To: <CAADnVQ+Mw=bG-HZ5KMMDWzr_JqcCwWNQNf-JRvRsTLZ6P7-tUw@mail.gmail.com>

On Mon, Jul 21, 2025 at 08:51:22AM -0700, Alexei Starovoitov wrote:
> On Mon, Jul 21, 2025 at 2:05 AM Thomas Weißschuh
> <thomas.weissschuh@linutronix.de> wrote:
> >
> > The code is unused since commit 98e20e5e13d2 ("bpfilter: remove bpfilter"),
> > remove it.
> 
> Correct, but we have plans to use it.
> Since it's not causing any problems we prefer to keep it
> to avoid reverting the removal later.

Plans to eventually use something are no reason to keep code that's been
unused for almost 2 years around.  Unless the removal would conflict with
currently queued up in linux-next code it is always better to just drop
it and reinstate it when (or rather usually IFF) it is used again.

  reply	other threads:[~2025-07-22  6:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21  9:04 [PATCH bpf-next 0/2] umd: Remove usermode driver framework Thomas Weißschuh
2025-07-21  9:04 ` [PATCH bpf-next 1/2] bpf/preload: Don't select USERMODE_DRIVER Thomas Weißschuh
2025-07-22  6:33   ` Christoph Hellwig
2025-07-21  9:04 ` [PATCH bpf-next 2/2] umd: Remove usermode driver framework Thomas Weißschuh
2025-07-21 15:51   ` Alexei Starovoitov
2025-07-22  6:33     ` Christoph Hellwig [this message]
2025-07-22 23:33       ` Eric W. Biederman
2025-07-22  6:34   ` Christoph Hellwig
2025-07-23  7:01     ` Thomas Weißschuh
2025-07-24  7:29       ` Christoph Hellwig
2025-07-24  8:38         ` Thomas Weißschuh
2025-07-29  7:37           ` Christoph Hellwig
2025-07-23 11:49     ` Christian Brauner
2025-07-23 16:27       ` Alexei Starovoitov
2025-07-31 10:22         ` Christian Brauner
2025-07-26 19:10 ` [PATCH bpf-next 0/2] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722063328.GA15403@lst.de \
    --to=hch@lst.de \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=ebiederm@xmission.com \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).