bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: netdev@vger.kernel.org
Cc: aleksander.lobakin@intel.com, alexanderduyck@fb.com,
	andrew+netdev@lunn.ch, ast@kernel.org, bpf@vger.kernel.org,
	corbet@lwn.net, daniel@iogearbox.net, davem@davemloft.net,
	edumazet@google.com, hawk@kernel.org, horms@kernel.org,
	john.fastabend@gmail.com, kernel-team@meta.com, kuba@kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	mohsin.bashr@gmail.com, pabeni@redhat.com, sdf@fomichev.me,
	vadim.fedorenko@linux.dev
Subject: [PATCH net-next V4 2/9] eth: fbnic: Update Headroom
Date: Wed, 13 Aug 2025 15:13:12 -0700	[thread overview]
Message-ID: <20250813221319.3367670-3-mohsin.bashr@gmail.com> (raw)
In-Reply-To: <20250813221319.3367670-1-mohsin.bashr@gmail.com>

Fbnic currently reserves a minimum of 64B headroom, but this is
insufficient for inserting additional headers (e.g., IPV6) via XDP, as
only 24 bytes are available for adjustment. To address this limitation,
increase the headroom to a larger value while ensuring better page use.
Although the resulting headroom (192B) is smaller than the recommended
value (256B), forcing the headroom to 256B would require aligning to
256B (as opposed to the current 128B), which can push the max headroom
to 511B.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h
index 7d27712d5462..66c84375e299 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h
@@ -50,8 +50,9 @@ struct fbnic_net;
 
 #define FBNIC_RX_TROOM \
 	SKB_DATA_ALIGN(sizeof(struct skb_shared_info))
+#define FBNIC_RX_HROOM_PAD		128
 #define FBNIC_RX_HROOM \
-	(ALIGN(FBNIC_RX_TROOM + NET_SKB_PAD, 128) - FBNIC_RX_TROOM)
+	(ALIGN(FBNIC_RX_TROOM + FBNIC_RX_HROOM_PAD, 128) - FBNIC_RX_TROOM)
 #define FBNIC_RX_PAD			0
 #define FBNIC_RX_PAYLD_OFFSET		0
 #define FBNIC_RX_PAYLD_PG_CL		0
-- 
2.47.3


  parent reply	other threads:[~2025-08-13 22:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 22:13 [PATCH net-next V4 0/9] eth: fbnic: Add XDP support for fbnic Mohsin Bashir
2025-08-13 22:13 ` [PATCH net-next V4 1/9] eth: fbnic: Add support for HDS configuration Mohsin Bashir
2025-08-13 22:13 ` Mohsin Bashir [this message]
2025-08-13 22:13 ` [PATCH net-next V4 3/9] eth: fbnic: Use shinfo to track frags state on Rx Mohsin Bashir
2025-08-13 22:13 ` [PATCH net-next V4 4/9] eth: fbnic: Prefetch packet headers " Mohsin Bashir
2025-08-13 22:13 ` [PATCH net-next V4 5/9] eth: fbnic: Add XDP pass, drop, abort support Mohsin Bashir
2025-08-21 12:52   ` Dan Carpenter
2025-08-13 22:13 ` [PATCH net-next V4 6/9] eth: fbnic: Add support for XDP queues Mohsin Bashir
2025-08-13 22:13 ` [PATCH net-next V4 7/9] eth: fbnic: Add support for XDP_TX action Mohsin Bashir
2025-08-13 22:13 ` [PATCH net-next V4 8/9] eth: fbnic: Collect packet statistics for XDP Mohsin Bashir
2025-08-13 22:13 ` [PATCH net-next V4 9/9] eth: fbnic: Report XDP stats via ethtool Mohsin Bashir
2025-08-19  9:20 ` [PATCH net-next V4 0/9] eth: fbnic: Add XDP support for fbnic patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250813221319.3367670-3-mohsin.bashr@gmail.com \
    --to=mohsin.bashr@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).