From: Amery Hung <ameryhung@gmail.com>
To: bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com,
andrii@kernel.org, daniel@iogearbox.net, kuba@kernel.org,
martin.lau@kernel.org, mohsin.bashr@gmail.com, saeedm@nvidia.com,
tariqt@nvidia.com, mbloch@nvidia.com,
maciej.fijalkowski@intel.com, kernel-team@meta.com
Subject: [RFC bpf-next v1 0/7] Add kfunc bpf_xdp_pull_data
Date: Mon, 25 Aug 2025 12:39:11 -0700 [thread overview]
Message-ID: <20250825193918.3445531-1-ameryhung@gmail.com> (raw)
Hi all,
This patchset introduces a new kfunc bpf_xdp_pull_data() to allow
pulling nonlinear xdp data. This may be useful when a driver places
headers in fragments. When an xdp program would like to keep parsing
packet headers using direct packet access, it can call
bpf_xdp_pull_data() to make the header available in the linear data
area. The kfunc can also be used to decapsulate the header in the
nonlinear data, as currently there is no easy way to do this.
This patchset also tries to fix an issue in the mlx5e driver. The driver
curretly assumes the packet layout to be unchanged after xdp program
runs and may generate packet with corrupted data or trigger kernel warning
if xdp programs calls layout-changing kfunc such as bpf_xdp_adjust_tail(),
bpf_xdp_adjust_head() or bpf_xdp_pull_data() introduced in this set.
Tested with the added bpf selftest using bpf test_run and also on
mlx5e with the tools/testing/selftests/drivers/net/xdp.py. mlx5e with
striding RQ will produce xdp_buff with empty linear data.
xdp.test_xdp_native_pass_mb would fail to parse the header before this
patchset.
Grateful for any feedback (especially the driver part).
Thanks!
Amery
Amery Hung (7):
net/mlx5e: Fix generating skb from nonlinear xdp_buff
bpf: Allow bpf_xdp_shrink_data to shrink a frag from head and tail
bpf: Support pulling non-linear xdp data
bpf: Clear packet pointers after changing packet data in kfuncs
bpf: Support specifying linear xdp packet data size in test_run
selftests/bpf: Test bpf_xdp_pull_data
selftests: drv-net: Pull data before parsing headers
.../net/ethernet/mellanox/mlx5/core/en_rx.c | 59 ++++++++----
include/net/xdp_sock_drv.h | 21 +++-
kernel/bpf/verifier.c | 13 +++
net/bpf/test_run.c | 9 +-
net/core/filter.c | 81 +++++++++++++---
.../bpf/prog_tests/xdp_context_test_run.c | 4 +-
.../selftests/bpf/prog_tests/xdp_pull_data.c | 96 +++++++++++++++++++
.../selftests/bpf/progs/test_xdp_pull_data.c | 36 +++++++
.../selftests/net/lib/xdp_native.bpf.c | 90 ++++++++++++++---
9 files changed, 356 insertions(+), 53 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_pull_data.c
create mode 100644 tools/testing/selftests/bpf/progs/test_xdp_pull_data.c
--
2.47.3
next reply other threads:[~2025-08-25 19:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 19:39 Amery Hung [this message]
2025-08-25 19:39 ` [RFC bpf-next v1 1/7] net/mlx5e: Fix generating skb from nonlinear xdp_buff Amery Hung
2025-08-27 13:45 ` Dragos Tatulea
2025-08-28 3:44 ` Amery Hung
2025-08-28 16:23 ` Dragos Tatulea
2025-08-28 13:41 ` Nimrod Oren
2025-08-25 19:39 ` [RFC bpf-next v1 2/7] bpf: Allow bpf_xdp_shrink_data to shrink a frag from head and tail Amery Hung
2025-08-28 13:43 ` Nimrod Oren
2025-08-25 19:39 ` [RFC bpf-next v1 3/7] bpf: Support pulling non-linear xdp data Amery Hung
2025-08-25 21:29 ` Stanislav Fomichev
2025-08-25 22:23 ` Amery Hung
2025-08-25 22:29 ` Jakub Kicinski
2025-08-25 22:36 ` Amery Hung
2025-08-25 22:46 ` Stanislav Fomichev
2025-08-25 22:58 ` Jakub Kicinski
2025-08-26 0:12 ` Stanislav Fomichev
2025-08-26 0:30 ` Jakub Kicinski
2025-08-25 22:39 ` Jakub Kicinski
2025-08-26 5:12 ` Amery Hung
2025-08-26 13:20 ` Jakub Kicinski
2025-08-26 13:44 ` Amery Hung
2025-08-25 19:39 ` [RFC bpf-next v1 4/7] bpf: Clear packet pointers after changing packet data in kfuncs Amery Hung
2025-08-25 19:39 ` [RFC bpf-next v1 5/7] bpf: Support specifying linear xdp packet data size in test_run Amery Hung
2025-08-25 19:39 ` [RFC bpf-next v1 6/7] selftests/bpf: Test bpf_xdp_pull_data Amery Hung
2025-08-25 19:39 ` [RFC bpf-next v1 7/7] selftests: drv-net: Pull data before parsing headers Amery Hung
2025-08-25 22:41 ` [RFC bpf-next v1 0/7] Add kfunc bpf_xdp_pull_data Jakub Kicinski
2025-08-26 19:38 ` Gal Pressman
2025-08-28 13:39 ` Nimrod Oren
2025-08-29 7:26 ` Amery Hung
2025-08-30 0:09 ` Jakub Kicinski
2025-08-29 18:21 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825193918.3445531-1-ameryhung@gmail.com \
--to=ameryhung@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=martin.lau@kernel.org \
--cc=mbloch@nvidia.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).