BPF List
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Siddharth Chintamaneni <sidchintamaneni@gmail.com>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, ast@kernel.org,
	daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
	eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
	john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
	haoluo@google.com, jolsa@kernel.org, djwillia@vt.edu,
	miloc@vt.edu, ericts@vt.edu, rahult@vt.edu, doniaghazy@vt.edu,
	quanzhif@vt.edu, jinghao7@illinois.edu,
	sidchintamaneni@gmail.com, memxor@gmail.com, egor@vt.edu,
	sairoop10@gmail.com, rjsu26@gmail.com
Subject: Re: [PATCH 3/4] bpf: runtime part of fast-path termination approach
Date: Mon, 8 Sep 2025 15:14:18 +0800	[thread overview]
Message-ID: <202509081431.PcY1azAC-lkp@intel.com> (raw)
In-Reply-To: <20250907230415.289327-4-sidchintamaneni@gmail.com>

Hi Siddharth,

kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/net]
[also build test ERROR on bpf-next/master bpf/master linus/master v6.17-rc5 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Siddharth-Chintamaneni/bpf-Introduce-new-structs-and-struct-fields-for-fast-path-termination/20250908-070655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git net
patch link:    https://lore.kernel.org/r/20250907230415.289327-4-sidchintamaneni%40gmail.com
patch subject: [PATCH 3/4] bpf: runtime part of fast-path termination approach
config: sh-randconfig-001-20250908 (https://download.01.org/0day-ci/archive/20250908/202509081431.PcY1azAC-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250908/202509081431.PcY1azAC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509081431.PcY1azAC-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/watchdog.c: In function 'is_softlockup':
>> kernel/watchdog.c:709:25: error: implicit declaration of function 'bpf_softlockup'; did you mean 'is_softlockup'? [-Wimplicit-function-declaration]
     709 |                         bpf_softlockup(now - touch_ts);
         |                         ^~~~~~~~~~~~~~
         |                         is_softlockup


vim +709 kernel/watchdog.c

   678	
   679	static int is_softlockup(unsigned long touch_ts,
   680				 unsigned long period_ts,
   681				 unsigned long now)
   682	{
   683		if ((watchdog_enabled & WATCHDOG_SOFTOCKUP_ENABLED) && watchdog_thresh) {
   684			/*
   685			 * If period_ts has not been updated during a sample_period, then
   686			 * in the subsequent few sample_periods, period_ts might also not
   687			 * be updated, which could indicate a potential softlockup. In
   688			 * this case, if we suspect the cause of the potential softlockup
   689			 * might be interrupt storm, then we need to count the interrupts
   690			 * to find which interrupt is storming.
   691			 */
   692			if (time_after_eq(now, period_ts + get_softlockup_thresh() / NUM_SAMPLE_PERIODS) &&
   693			    need_counting_irqs())
   694				start_counting_irqs();
   695	
   696			/*
   697			 * A poorly behaving BPF scheduler can live-lock the system into
   698			 * soft lockups. Tell sched_ext to try ejecting the BPF
   699			 * scheduler when close to a soft lockup.
   700			 */
   701			if (time_after_eq(now, period_ts + get_softlockup_thresh() * 3 / 4))
   702				scx_softlockup(now - touch_ts);
   703	
   704			/*
   705			 * Long running BPF programs can cause CPU's to stall.
   706			 * So trigger fast path termination to terminate such BPF programs.
   707			 */
   708			if (time_after_eq(now, period_ts + get_softlockup_thresh() * 3 / 4))
 > 709				bpf_softlockup(now - touch_ts);
   710	
   711			/* Warn about unreasonable delays. */
   712			if (time_after(now, period_ts + get_softlockup_thresh()))
   713				return now - touch_ts;
   714		}
   715		return 0;
   716	}
   717	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-09-08  7:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-07 23:04 [PATCH 0/4] bpf: Fast-Path approach for BPF program termination Siddharth Chintamaneni
2025-09-07 23:04 ` [PATCH 1/4] bpf: Introduce new structs and struct fields for fast path termination Siddharth Chintamaneni
2025-09-17  2:11   ` Kumar Kartikeya Dwivedi
2025-09-17  3:38     ` Siddharth Chintamaneni
2025-09-07 23:04 ` [PATCH 2/4] bpf: Creating call sites table to stub instructions during runtime Siddharth Chintamaneni
2025-09-07 23:04 ` [PATCH 3/4] bpf: runtime part of fast-path termination approach Siddharth Chintamaneni
2025-09-08  6:01   ` kernel test robot
2025-09-08  7:14   ` kernel test robot [this message]
2025-09-17  2:11   ` Kumar Kartikeya Dwivedi
2025-09-17  4:01     ` Siddharth Chintamaneni
2025-09-07 23:04 ` [PATCH 4/4] selftests/bpf: Adds selftests to check termination of long running nested bpf loops Siddharth Chintamaneni
2025-09-17  2:13 ` [PATCH 0/4] bpf: Fast-Path approach for BPF program termination Kumar Kartikeya Dwivedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509081431.PcY1azAC-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=djwillia@vt.edu \
    --cc=doniaghazy@vt.edu \
    --cc=eddyz87@gmail.com \
    --cc=egor@vt.edu \
    --cc=ericts@vt.edu \
    --cc=haoluo@google.com \
    --cc=jinghao7@illinois.edu \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=miloc@vt.edu \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=quanzhif@vt.edu \
    --cc=rahult@vt.edu \
    --cc=rjsu26@gmail.com \
    --cc=sairoop10@gmail.com \
    --cc=sdf@fomichev.me \
    --cc=sidchintamaneni@gmail.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox