From: Leon Hwang <leon.hwang@linux.dev>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, ameryhung@gmail.com,
menglong8.dong@gmail.com, chen.dylane@linux.dev,
leon.hwang@linux.dev, kernel-patches-bot@fb.com
Subject: [PATCH bpf-next v4 0/2] bpf: Allow union argument in trampoline based programs
Date: Fri, 19 Sep 2025 12:41:08 +0800 [thread overview]
Message-ID: <20250919044110.23729-1-leon.hwang@linux.dev> (raw)
While tracing 'release_pages' with bpfsnoop[0], the verifier reports:
The function release_pages arg0 type UNION is unsupported.
However, it should be acceptable to trace functions that have 'union'
arguments.
This patch set enables such support in the verifier by allowing 'union'
as a valid argument type.
Changes:
v3 -> v4:
* Address comments from Alexei:
* Trim bpftrace output in patch #1 log.
* Drop the referenced commit info and the test output in patch #2 log.
v2 -> v3:
* Address comments from Alexei:
* Reuse the existing flag BTF_FMODEL_STRUCT_ARG.
* Update the comment of the flag BTF_FMODEL_STRUCT_ARG.
v1 -> v2:
* Add 16B 'union' argument support in x86_64 trampoline.
* Update selftests using bpf_testmod.
* Add test case about 16-bytes 'union' argument.
* Address comments from Alexei:
* Study the patch set about 'struct' argument support.
* Update selftests to cover more cases.
v1: https://lore.kernel.org/bpf/20250905133226.84675-1-leon.hwang@linux.dev/
Links:
[0] https://github.com/bpfsnoop/bpfsnoop
Leon Hwang (2):
bpf: Allow union argument in trampoline based programs
selftests/bpf: Add union argument tests using fexit programs
include/linux/bpf.h | 2 +-
kernel/bpf/btf.c | 8 ++---
.../selftests/bpf/prog_tests/tracing_struct.c | 29 ++++++++++++++++
.../selftests/bpf/progs/tracing_struct.c | 33 +++++++++++++++++++
.../selftests/bpf/test_kmods/bpf_testmod.c | 31 +++++++++++++++++
5 files changed, 98 insertions(+), 5 deletions(-)
--
2.51.0
next reply other threads:[~2025-09-19 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 4:41 Leon Hwang [this message]
2025-09-19 4:41 ` [PATCH bpf-next v4 1/2] bpf: Allow union argument in trampoline based programs Leon Hwang
2025-09-19 4:41 ` [PATCH bpf-next v4 2/2] selftests/bpf: Add union argument tests using fexit programs Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919044110.23729-1-leon.hwang@linux.dev \
--to=leon.hwang@linux.dev \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chen.dylane@linux.dev \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-patches-bot@fb.com \
--cc=martin.lau@linux.dev \
--cc=menglong8.dong@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox