From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C58D149C6F for ; Fri, 3 Oct 2025 11:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759492192; cv=none; b=hWA6ll01uO+U899G4XYp7Rh0oqjtwnkF97Ni1EAS22xkNFDFD3fUeYNvjwU4wnWSVAD+yd8Nf6F6AZiWqcZT8ValE3ocErM5t2H7I5gRT+hOMlx6dWwxDyShsSHE7yCelv+/VOXnEQ06LPysnd0DF4KuUpYHkSkwLq5bZ6O2sOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759492192; c=relaxed/simple; bh=ChVp9KK5VYC24c4PGIVC8sIuSiyWxtH3Wug7gY5L/4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kZKxh689Wm38PAfFHFt8pXt2dSwsRTZr/qOMdw6u7VkAIy7PrKrpLqzZdUr7lOkZujCNmJGUkneXdra8F2zSyuAKWs9sucIvJAFrz9ZpZIuVzKpY+6QAcA7XcJ/sN6h2AYxwqcYffODKfSy+P8Cn449CkSQhasuEWL8L6+p3PGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZIgVcUgD; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZIgVcUgD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759492190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lSqrqsAeKH98aMV7qW4Dfz7O++V6OieZSCKqHyzEpCM=; b=ZIgVcUgDUiDFhkxALYYIZjcm8Zvq2DArMOqhQch+gyIkcHn0kYpyUpwGKpxtIWy6RvtkSV bHRmlpJJCX7OgFcq8Dm/77a0mRInECoRpt7R2dcds+k3W+lruYldefPNv15K+6glI3UGOc tr1M39Q/B9yLZSIRJh3MsQsPlWORHc8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-kEFwZDOLPLaNPfrwhYlYDg-1; Fri, 03 Oct 2025 07:49:48 -0400 X-MC-Unique: kEFwZDOLPLaNPfrwhYlYDg-1 X-Mimecast-MFC-AGG-ID: kEFwZDOLPLaNPfrwhYlYDg_1759492186 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B3E501800370; Fri, 3 Oct 2025 11:49:44 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.40]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 4FF0C180035E; Fri, 3 Oct 2025 11:49:36 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 3 Oct 2025 13:48:23 +0200 (CEST) Date: Fri, 3 Oct 2025 13:48:14 +0200 From: Oleg Nesterov To: Jiri Olsa Cc: Peter Zijlstra , Andrii Nakryiko , Linus Torvalds , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, Song Liu , Yonghong Song , John Fastabend , Hao Luo , Steven Rostedt , Masami Hiramatsu , Alan Maguire , David Laight , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Ingo Molnar , Jann Horn , Alejandro Colomar Subject: Re: [PATCH] uprobe: Move arch_uprobe_optimize right after handlers execution Message-ID: <20251003114814.GA14763@redhat.com> References: <20251001132449.178759-1-jolsa@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251001132449.178759-1-jolsa@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 10/01, Jiri Olsa wrote: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -2765,6 +2765,9 @@ static void handle_swbp(struct pt_regs *regs) > > handler_chain(uprobe, regs); > > + /* Try to optimize after first hit. */ > + arch_uprobe_optimize(&uprobe->arch, bp_vaddr); > + > /* > * If user decided to take execution elsewhere, it makes little sense > * to execute the original instruction, so let's skip it. > @@ -2772,9 +2775,6 @@ static void handle_swbp(struct pt_regs *regs) > if (instruction_pointer(regs) != bp_vaddr) > goto out; > > - /* Try to optimize after first hit. */ > - arch_uprobe_optimize(&uprobe->arch, bp_vaddr); > - > if (arch_uprobe_skip_sstep(&uprobe->arch, regs)) > goto out; Acked-by: Oleg Nesterov