From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8734521D3D9 for ; Wed, 15 Oct 2025 02:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760496657; cv=none; b=gmkUtjSumgR7gNO5NetTQZ2ga4rYkxzJ4sRoJ9h8hlMoQauzRHwzd4fUCOh+TMsWvat65uaPy6CEWkHIkroB/+/ktnoe8bmZolzgMKNkpXaNRzbtWdRK7tnTQMtR5phSCOsa3FdlXrO5e3HYngnDodH77yvNY5Zk6q5iou6DmPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760496657; c=relaxed/simple; bh=SRNf4UNoXj0fG4TsIdCYfur89uC/7Bjg76Zbybn6ais=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n8Waik9OfOTscCwX1NMzsk6Gv5aaCq31zDQnNyn3lmL+F+OTkRo+8TY5B4YNTtIGf42nclIv8blFrwxQRYvBAq9QuNU6AKkU7CQTjmDPgUrEh7xxE0tXY0LrHcE/Yh3TzscdrLZ0SQStHAyf1dzQXpt5s/bAod/1QsO9nV85ajI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h7+Pu+pm; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h7+Pu+pm" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-273a0aeed57so6947755ad.1 for ; Tue, 14 Oct 2025 19:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760496656; x=1761101456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JMeNinbxn1Ia1bk4viRlQhx3ffdSmm43VBmbl3H22uM=; b=h7+Pu+pmif+ywlWZEcPTyRLfVK0h5JdnyVQpFBkriKp6XBVVVichWa8BUIby+HD2+i dEz28dIDW7n1Kn4zzQqrfDQV6ScM+OeZTXTX8kLCnOpQMLpYZW6Hw4Y6hPC45LJHVgjR GYwbcBRrgh1gjqBN0FzLGcmK+9lR/WWz1cdMUrJ1vM+V3sfGFD1PYhVItXSPE0ENdvhi EVl3ZWw+slSZCwTvpqK+gF6rouLkxAjbPeIjR+FolvCR3LIBxrBsqwekeXQasncgKtWy fcfcjm0yKVcW+9BTk8pcgeUtYS1EWHuUlDWWE+lBBK8b9bpqWPwSyXCeh65P2ZyCWS8/ pJHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760496656; x=1761101456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JMeNinbxn1Ia1bk4viRlQhx3ffdSmm43VBmbl3H22uM=; b=dldmb0zIh2hRsloXF6ywYgtLFg6ri+NL2fjYueysVMT7LAHuO0zPeL5xVxhxlEhRoy CL1hA8FlyVlEPwWYoEzJfR1a3MyEoH8gUmPvBOdJ4gov2YIhxavURXM/PMG9zBoL4oEK tHbn7Q37pnols1dHhtX8pHruPRhPUAiwrlkYveTV0ehaNwsPKHSYWRSyQrKf4lM2j2D8 HNbpfC7u8cqVMU6ZkPS9JJFYjhgWCo8vHQZ6O5qSEIOe2aVnocF1unZTK4nxv3ZR6g6A cvZgIy3kxh4Ke9gN9Uw5C3pv7VCzIFeIWG6uKhPzeY1Diz8Fg1bLJZHodf6SHf4Q+a7R dSqQ== X-Forwarded-Encrypted: i=1; AJvYcCUPmgbg04EK4kHFR9JfDFdmCncywFVKuC+7c/5EJFQMVI4nEMhyRvrk89avDRDuldDpeMs=@vger.kernel.org X-Gm-Message-State: AOJu0YwdNGBtz1A2vYnhbQJxG7RPhOIfckFA4UT7WeWM1vlTU+k1/yLv SJsH876hwcEEzn6YAQicEqVTsjy5ZGxd8X+C8S8DQVRyrW2liHnTRJO+ X-Gm-Gg: ASbGnctqu2I+RoMVuedE0Lilf9FBkGMArS4MFW6MhXGScxRwTMZVwOoX0gfi82paEkL cRJA6oI50qxQrpmm79F/+vNxLcdM5AFo6/rM3GvTmghBoZScWAu5XT0Hz1u29Xkx69xdBfnI8S8 TesCrhCpGqHFEm12VNb66Z96HWYnaBkDhD0B31dMYtkhF+lTS/8IOtmhRyyjys+K6F6bntmGzWc DBvW7vUjlMYbwv/Pgwl/wmOvr9j9AmEc5uzyqu1aeBygXAqhp6K+cM2tecuAXRFYMBq7BxCGrRd xHOqLxfVH+5FJ/XGNUb0t0Gp/wY5pQ+yLSPT5zWqI1E2+w4aic1e0+3XrGe+m2IFUE18FgtNh2o BEjkFlxSyiA1JR9Q9VOmpdtu5ZLo8r79macYAp9Bgg+4raYpfK0Z0aKIWqVJgfBl2gFOYtQsWJs Lt/wOPmTnpHJL8fas= X-Google-Smtp-Source: AGHT+IGRIAcjywFUyrUMh6UonIN+ZpPlKp8qOaB0t1ePLb+D0r1qb3GCYMQhiAzaFL5teWBbn4+BVA== X-Received: by 2002:a17:903:3846:b0:265:b60f:d18 with SMTP id d9443c01a7336-29027e5e015mr278711075ad.1.1760496655731; Tue, 14 Oct 2025 19:50:55 -0700 (PDT) Received: from laptop.dhcp.broadcom.net ([192.19.38.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034e1cbadsm178887365ad.33.2025.10.14.19.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 19:50:55 -0700 (PDT) From: Xing Guo To: alexei.starovoitov@gmail.com Cc: andrii.nakryiko@gmail.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, higuoxing@gmail.com, linux-kselftest@vger.kernel.org, olsajiri@gmail.com, sveiss@meta.com Subject: [PATCH v2] selftests: arg_parsing: Ensure data is flushed to disk before reading. Date: Wed, 15 Oct 2025 10:50:49 +0800 Message-ID: <20251015025049.9492-1-higuoxing@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Recently, I noticed a selftest failure in my local environment. The test_parse_test_list_file writes some data to /tmp/bpf_arg_parsing_test.XXXXXX and parse_test_list_file() will read the data back. However, after writing data to that file, we forget to call fsync() and it's causing testing failure in my laptop. This patch helps fix it by adding the missing fsync() call. Signed-off-by: Xing Guo --- tools/testing/selftests/bpf/prog_tests/arg_parsing.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/arg_parsing.c b/tools/testing/selftests/bpf/prog_tests/arg_parsing.c index bb143de68875..0f99f06116ea 100644 --- a/tools/testing/selftests/bpf/prog_tests/arg_parsing.c +++ b/tools/testing/selftests/bpf/prog_tests/arg_parsing.c @@ -140,9 +140,11 @@ static void test_parse_test_list_file(void) fprintf(fp, "testA/subtest2\n"); fprintf(fp, "testC_no_eof_newline"); fflush(fp); - - if (!ASSERT_OK(ferror(fp), "prepare tmp")) - goto out_fclose; + if (!ASSERT_OK(ferror(fp), "prepare tmp")) { + fclose(fp); + goto out_remove; + } + fclose(fp); init_test_filter_set(&set); @@ -160,8 +162,6 @@ static void test_parse_test_list_file(void) free_test_filter_set(&set); -out_fclose: - fclose(fp); out_remove: remove(tmpfile); } -- 2.51.0