From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0EE4B67A for ; Thu, 16 Oct 2025 03:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760586819; cv=none; b=MkjbnzvdWufv5dHgqEQ/W1K3XxiYYW3d6WEvQPCoIGuI0zz2vg/lXU4ZmdsDA0TXqw3TWvl6N4UdEi7QTD3uPwWJNzHa2K/nVsIzUO0G1v8kzkVgxEVeKPCAiM4enpoMAWaOf71Yqgpgu1tqk6Ml2MszUUxE3niAY3fHBBqGpgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760586819; c=relaxed/simple; bh=+Bi0k7yeEVhElVYsr9bEFjVbio42J+whEdTcbqgJylY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gfIanjOqtD4/gyfoRNmjcxAfpT8KEQ24gip+i2Vew7pCIU3kESWhJkrNvElRWNBz6KEWkKQQ5Lqt+Xw4JqORXGgGJYWZ5UbzhaQxlVCi4wFm6uUfESM5OCRqThMh+/1zMQ0f3kW9bzmDH5ftdIIPy7hCz/Dbg4dfeuyIzru9BrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=caIVXEoP; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="caIVXEoP" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-78118e163e5so1434571b3a.0 for ; Wed, 15 Oct 2025 20:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760586817; x=1761191617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BjH/Xk+Vw9IhbcZ1lknKGKFAYoqovFnR+/YWG7tmcfk=; b=caIVXEoP5MWayTqnL+Mr1J4qxOaPiRdidDy2At10CWfnKdI9njcVZVtLN7Hk20A9m9 VQNCR+pw5aM14/Ty6UpG42LoAyBSU3DPhAMu4uWRF3yvfqDaU5Fv5rXCvGaH/orznudO 7PoeM7Lm6wRY8NdEF9xioiXQsyb1xOCRg4hxttcNFCIjRb9RJfqHIom8nkJZB0bEsoA/ meTdJIbNgcwOGVh3iOyCC/I0o0OPMyZOr9zJggPeZrepn/3+NHC1t/PuC8w35qt2Skq0 fMHHreFkw8rvVbOjnjCLjY3S4p02REXTsKiLwhQiq9RPW+AJ9KKX/i1t/A8EKVGJ62RP ri/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760586817; x=1761191617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BjH/Xk+Vw9IhbcZ1lknKGKFAYoqovFnR+/YWG7tmcfk=; b=iQAvs8SVoFo3oanePl0P+H/fN+n6z4am83wzAp4PBPXoz6s+jfI1lvo/RMBNQMOKaW hBdsL/P6v/wWBXva1iMfY7o6GxyeX4kHRLKGVr4iqZLQx6XDRRJoDkObrLitrHtp0GUD yUL/v1O2mTKOgOuKGEdBL5/+CZz2OTCn2cB+XddOejVUxjyTQeVS/3X/JzjWGqpEKF7l WjSsWlNTHd1yOdpSOxSRYYj1bTJaftAqtN0jWg0H8CnmuSKiAns9aGTUYqtRRUQR26DX IZ2odx0HWnBXB5RU2kMbf1CuE41YUKfvSeLUI32hA59zll0pLFBRY8lCWcu3Zko3hBwH 08fw== X-Forwarded-Encrypted: i=1; AJvYcCWUJsnF5/XmNrXFatt8bAzqC9/3qAFzKw9aSoaAlMNjIm8Oof9Ta5q+Pn5kIm8E0BSTdSM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx29pIgiZKwqokaCmO8GVVUenzzb1tw5K/WT1nuJ5Bc7sOBOvRw xKkBW8nw0BYUnqs5fXM3ve7n7Qafqzplyfxx5JhVNp4zfL87Hp2pxePY X-Gm-Gg: ASbGncutWbqq9khehjfaPfecpd5SdGO1j1y0ouap6whFdmDVKWNBULpAOKs1BXk/dZG wc9P92tB8IXjhtE8bH4abe/o0o1cldD+yOHQaX7Yg2hTsicecswo4CgsRf604B/H5gJbhce1Rgy adjddlpJLOc8uoxNtk4rJwyAwQ8Ky5fjewP9tdrMsLB8ml97uIKdRTGHv8XCvAIvVyJj5w4j8by 3QLZSY4XsqExdXawc00S13dUdWArvkwL2kUOtO+rP1zzwf2/Z+qmuO/Z2sfaTXHFo48SQ2X2+GO iKSHMVYLNoXwEFHRMdzwdef526Vz5pzHDkhs+tNOqxC3yNivjxL3W72wYzP/scwTObDLe9Vsq7g Y+7YvtWBxiwcUFd50m6MPLg30c5fdUOg6fz9ud4oFCnXPTF4NcHR2Im5XDpqEvCaCuxeDXmAEHL cKLj8CsUaQyP12mipdAfTS03COhg7d9lYGdobNi9mw6HlrJyGncw== X-Google-Smtp-Source: AGHT+IF5L3KREyHjFSPQncpJROTSoshms/ZTe2ibdM8WJ0gkfy/b4DYL+CIu7RSZ9C1y3z7bKhMfXA== X-Received: by 2002:a05:6a20:938c:b0:2b9:6b0b:66be with SMTP id adf61e73a8af0-33495d82c1dmr3487745637.14.1760586816941; Wed, 15 Oct 2025 20:53:36 -0700 (PDT) Received: from laptop.dhcp.broadcom.net ([192.19.38.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33bb6632e72sm16065a91.19.2025.10.15.20.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Oct 2025 20:53:36 -0700 (PDT) From: Xing Guo To: andrii.nakryiko@gmail.com Cc: alexei.starovoitov@gmail.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, higuoxing@gmail.com, linux-kselftest@vger.kernel.org, olsajiri@gmail.com, sveiss@meta.com Subject: [PATCH bpf v6] selftests: arg_parsing: Ensure data is flushed to disk before reading. Date: Thu, 16 Oct 2025 11:53:30 +0800 Message-ID: <20251016035330.3217145-1-higuoxing@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit test_parse_test_list_file writes some data to /tmp/bpf_arg_parsing_test.XXXXXX and parse_test_list_file() will read the data back. However, after writing data to that file, we forget to call fsync() and it's causing testing failure in my laptop. This patch helps fix it by adding the missing fsync() call. Fixes: 64276f01dce8 ("selftests/bpf: Test_progs can read test lists from file") Signed-off-by: Xing Guo --- tools/testing/selftests/bpf/prog_tests/arg_parsing.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/arg_parsing.c b/tools/testing/selftests/bpf/prog_tests/arg_parsing.c index fbf0d9c2f58b..e27d66b75fb1 100644 --- a/tools/testing/selftests/bpf/prog_tests/arg_parsing.c +++ b/tools/testing/selftests/bpf/prog_tests/arg_parsing.c @@ -144,6 +144,9 @@ static void test_parse_test_list_file(void) if (!ASSERT_OK(ferror(fp), "prepare tmp")) goto out_fclose; + if (!ASSERT_OK(fsync(fileno(fp)), "fsync tmp")) + goto out_fclose; + init_test_filter_set(&set); if (!ASSERT_OK(parse_test_list_file(tmpfile, &set, true), "parse file")) -- 2.51.0