From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
razor@blackwall.org, pabeni@redhat.com, willemb@google.com,
sdf@fomichev.me, john.fastabend@gmail.com, martin.lau@kernel.org,
jordan@jrife.io, maciej.fijalkowski@intel.com,
magnus.karlsson@intel.com, dw@davidwei.uk, toke@redhat.com,
yangzhenze@bytedance.com, wangdongdong.6@bytedance.com
Subject: Re: [PATCH net-next v3 02/15] net: Implement netdev_nl_bind_queue_doit
Date: Thu, 23 Oct 2025 19:28:42 -0700 [thread overview]
Message-ID: <20251023192842.31a2efc0@kernel.org> (raw)
In-Reply-To: <20251020162355.136118-3-daniel@iogearbox.net>
On Mon, 20 Oct 2025 18:23:42 +0200 Daniel Borkmann wrote:
> +void netdev_rx_queue_peer(struct net_device *src_dev,
> + struct netdev_rx_queue *src_rxq,
> + struct netdev_rx_queue *dst_rxq)
> +{
> + netdev_assert_locked(src_dev);
> + netdev_assert_locked(dst_rxq->dev);
> +
> + netdev_hold(src_dev, &src_rxq->dev_tracker, GFP_KERNEL);
Isn't ->dev_tracker already used by sysfs?
Are you handling the underlying device going away?
> + __netdev_rx_queue_peer(src_rxq, dst_rxq);
> +}
next prev parent reply other threads:[~2025-10-24 2:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 16:23 [PATCH net-next v3 00/15] netkit: Support for io_uring zero-copy and AF_XDP Daniel Borkmann
2025-10-20 16:23 ` [PATCH net-next v3 01/15] net: Add bind-queue operation Daniel Borkmann
2025-10-22 11:19 ` Nikolay Aleksandrov
2025-10-24 2:12 ` Jakub Kicinski
2025-10-24 10:15 ` Daniel Borkmann
2025-10-24 18:11 ` Stanislav Fomichev
2025-10-24 19:17 ` Daniel Borkmann
2025-10-20 16:23 ` [PATCH net-next v3 02/15] net: Implement netdev_nl_bind_queue_doit Daniel Borkmann
2025-10-22 11:17 ` Nikolay Aleksandrov
2025-10-22 11:26 ` Daniel Borkmann
2025-10-23 10:17 ` Paolo Abeni
2025-10-23 12:46 ` Daniel Borkmann
2025-10-23 10:27 ` Paolo Abeni
2025-10-23 12:48 ` Daniel Borkmann
2025-10-24 2:08 ` Jakub Kicinski
2025-10-28 21:59 ` David Wei
2025-10-28 23:44 ` Jakub Kicinski
2025-10-29 0:38 ` David Wei
2025-10-24 2:28 ` Jakub Kicinski [this message]
2025-10-28 22:41 ` David Wei
2025-10-29 16:46 ` Daniel Borkmann
2025-10-24 18:20 ` Stanislav Fomichev
2025-10-24 19:15 ` Daniel Borkmann
2025-10-20 16:23 ` [PATCH net-next v3 03/15] net: Add peer info to queue-get response Daniel Borkmann
2025-10-22 11:23 ` Nikolay Aleksandrov
2025-10-24 2:33 ` Jakub Kicinski
2025-10-24 12:59 ` Daniel Borkmann
2025-10-24 23:18 ` Jakub Kicinski
2025-10-29 2:08 ` David Wei
2025-10-29 22:47 ` Jakub Kicinski
2025-10-20 16:23 ` [PATCH net-next v3 04/15] net, ethtool: Disallow peered real rxqs to be resized Daniel Borkmann
2025-10-22 11:25 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 05/15] net: Proxy net_mp_{open,close}_rxq for mapped queues Daniel Borkmann
2025-10-22 12:50 ` Nikolay Aleksandrov
2025-10-24 18:36 ` Stanislav Fomichev
2025-10-29 2:07 ` David Wei
2025-10-20 16:23 ` [PATCH net-next v3 06/15] xsk: Move NETDEV_XDP_ACT_ZC into generic header Daniel Borkmann
2025-10-22 12:51 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 07/15] xsk: Move pool registration into single function Daniel Borkmann
2025-10-22 12:52 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 08/15] xsk: Add small helper xp_pool_bindable Daniel Borkmann
2025-10-22 12:52 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 09/15] xsk: Change xsk_rcv_check to check netdev/queue_id from pool Daniel Borkmann
2025-10-20 16:23 ` [PATCH net-next v3 10/15] xsk: Proxy pool management for mapped queues Daniel Borkmann
2025-10-20 16:23 ` [PATCH net-next v3 11/15] netkit: Add single device mode for netkit Daniel Borkmann
2025-10-22 13:13 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 12/15] netkit: Document fast vs slowpath members via macros Daniel Borkmann
2025-10-22 13:02 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 13/15] netkit: Implement rtnl_link_ops->alloc and ndo_queue_create Daniel Borkmann
2025-10-22 13:00 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 14/15] netkit: Add io_uring zero-copy support for TCP Daniel Borkmann
2025-10-22 13:12 ` Nikolay Aleksandrov
2025-10-20 16:23 ` [PATCH net-next v3 15/15] netkit: Add xsk support for af_xdp applications Daniel Borkmann
2025-10-22 14:27 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023192842.31a2efc0@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=john.fastabend@gmail.com \
--cc=jordan@jrife.io \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=toke@redhat.com \
--cc=wangdongdong.6@bytedance.com \
--cc=willemb@google.com \
--cc=yangzhenze@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).