Re: [PATCH v2 22/50] convert efivarfs

Christian Brauner
2025-11-11T10:56:34Z

On Sun, Nov 09, 2025 at 08:40:18PM +0000, Al Viro wrote:
> On Wed, Nov 05, 2025 at 02:43:34PM +0100, Christian Brauner wrote:
>
> > -static void filesystems_freeze_callback(struct super_block *sb, void *unused)
> > +static void filesystems_freeze_callback(struct super_block *sb, void *bool_freeze_all)
> > {
> > + bool freeze_all = *(bool *)bool_freeze_all;
> > +
> > if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super)
> > return;
> >
> > + if (!freeze_all) {
>
> Minor nitpick: do we even need a dereference here? Just check
> whether the argument is NULL and adjust the caller...

Yup, sounds good.