Re: [PATCH v2 19/50] convert tracefs

Steven Rostedt
2025-10-28T15:36:52Z

On Tue, 28 Oct 2025 00:45:38 +0000
Al Viro <viro@zeniv.linux.org.uk> wrote:

> A mix of persistent and non-persistent dentries in there. Strictly
> speaking, no need for kill_litter_super() anyway - it pins an internal
> mount whenever a persistent dentry is created, so at fs shutdown time
> there won't be any to deal with.
>
> However, let's make it explicit - replace d_instantiate() with
> d_make_persistent() + dput() (the latter in tracefs_end_creating(),
> where it folds with inode_unlock() into simple_done_creating())
> for dentries we want persistent and have d_make_discardable() done
> either by simple_recursive_removal() (used by tracefs_remove())
> or explicitly in eventfs_remove_events_dir().
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

I ran the tracing selftests and some other tests I have against this and
nothing interesting happened. I didn't run my full test suite, but it looks
sane to me.

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve