Re: [PATCH v2 34/50] selinuxfs: new helper for attaching files to tree

Paul Moore
2025-10-28T23:51:16Z

On Mon, Oct 27, 2025 at 8:46 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> allocating dentry after the inode has been set up reduces the amount
> of boilerplate - "attach this inode under that name and this parent
> or drop inode in case of failure" simplifies quite a few places.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> security/selinux/selinuxfs.c | 160 +++++++++++++++--------------------
> 1 file changed, 66 insertions(+), 94 deletions(-)

Looks fine to me, thanks Al. If for some reason the rest of the
patchset doesn't go anywhere, let me know and I can take this patch;
it seems like a nice improvement independent of the rest.

Acked-by: Paul Moore <paul@paul-moore.com>

--
paul-moore.com