Re: [PATCH v2 23/50] convert spufs

Al Viro
2025-10-28T01:33:33Z

On Tue, Oct 28, 2025 at 01:15:38AM +0000, bot+bpf-ci@kernel.org wrote:

> >
> > - d_instantiate(dentry, inode);
> > - dget(dentry);
> > inc_nlink(dir);
> > inc_nlink(d_inode(dentry));
> > + d_make_persistent(dentry, inode);
> > return ret;
>
> In spufs_mkgang(), can this call inc_nlink(d_inode(dentry)) before
> d_make_persistent() instantiates the dentry? The dentry is not
> instantiated until d_make_persistent() is called, so d_inode(dentry)
> returns NULL here.

Screwed-up editing - that should've been inc_nlink(inode), of course.
Fixed...