From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E38631DD8A; Tue, 11 Nov 2025 06:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762844132; cv=none; b=lX7GrGgCb195JlYze4Cpwfm9i6KUYhhkC9+ZnCTMgHxUZ/e1dzMeUlplQINWz5tILo1l27AMXw7lP2grxk7uVyogJ6NVbNr7Id7c/a8KRN4Z+aa4IqX7nvWrgPTtw5m43LyLn6t9kxsvv2fF4QnveRLhGlE1NR4Kq01tRx71Tkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762844132; c=relaxed/simple; bh=drdrUYlNf0PCOpfWhx6O/F9lOTCkn1Mjer9awXrbASA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ipEFAA6IDZOqk0fjGibRJzjgsvrRwgi2hk0tQ0QaRBgZKaRfcL0s5b4bajFVP1rv9GaxuTTvcl25bcnkcY/xydT+SME+IB4zNNWchQp7FDU3lshn3QB3XCqZsupGjM4Lg/9Ub0jUvm0JSqjFZh8aG7k5SmypEiwtattYF8hLLcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=WF+XWuZj; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="WF+XWuZj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=LZ6yrPf10XyjUbpb0uoz9zDvZV76d0sxqTJxoq2o+VY=; b=WF+XWuZjccDaSV23t3ZCfvZAqt Hohm1giogHgJTgIjz+BM3jhjjTLoMdwPuodAY78QeOg3GUBHZu1BGBA/33p1gpzOLqgCHsjuNsjeO sQETYjkIyeMGltUwxf2aDzIQ7PxRO17kuJJhunXpDKie7s9abJc1ZOCPUQ4749pSp/uNXUiW0pz9g 5StKOHjXdngU9MjIt4G/vCYSMTp+hyY6F4EcS2NOjjVRYMEIOouxZxb3c/rhJhZKAuyInpomcfpJH 67Y7Q5I6dHBaVWqSe0Uuoe3F6FPAUvCjSQfpY1qedvsKXQE0I+R1n4CVwDF5AEHhuS7B8QobBm68r RCaB/VuQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIiHk-0000000Bwyw-24hu; Tue, 11 Nov 2025 06:55:24 +0000 From: Al Viro To: linux-fsdevel@vger.kernel.org Cc: torvalds@linux-foundation.org, brauner@kernel.org, jack@suse.cz, raven@themaw.net, miklos@szeredi.hu, neil@brown.name, a.hindborg@kernel.org, linux-mm@kvack.org, linux-efi@vger.kernel.org, ocfs2-devel@lists.linux.dev, kees@kernel.org, rostedt@goodmis.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, paul@paul-moore.com, casey@schaufler-ca.com, linuxppc-dev@lists.ozlabs.org, john.johansen@canonical.com, selinux@vger.kernel.org, borntraeger@linux.ibm.com, bpf@vger.kernel.org Subject: [PATCH v3 21/50] debugfs: remove duplicate checks in callers of start_creating() Date: Tue, 11 Nov 2025 06:54:50 +0000 Message-ID: <20251111065520.2847791-22-viro@zeniv.linux.org.uk> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251111065520.2847791-1-viro@zeniv.linux.org.uk> References: <20251111065520.2847791-1-viro@zeniv.linux.org.uk> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Al Viro we'd already verified that DEBUGFS_ALLOW_API was there in start_creating() - it would've failed otherwise Acked-by: Greg Kroah-Hartman Signed-off-by: Al Viro --- fs/debugfs/inode.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 682120fdbb17..25a554331ac4 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -433,11 +433,6 @@ static struct dentry *__debugfs_create_file(const char *name, umode_t mode, if (IS_ERR(dentry)) return dentry; - if (!(debugfs_allow & DEBUGFS_ALLOW_API)) { - failed_creating(dentry); - return ERR_PTR(-EPERM); - } - inode = debugfs_get_inode(dentry->d_sb); if (unlikely(!inode)) { pr_err("out of free dentries, can not create file '%s'\n", @@ -583,11 +578,6 @@ struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) if (IS_ERR(dentry)) return dentry; - if (!(debugfs_allow & DEBUGFS_ALLOW_API)) { - failed_creating(dentry); - return ERR_PTR(-EPERM); - } - inode = debugfs_get_inode(dentry->d_sb); if (unlikely(!inode)) { pr_err("out of free dentries, can not create directory '%s'\n", @@ -630,11 +620,6 @@ struct dentry *debugfs_create_automount(const char *name, if (IS_ERR(dentry)) return dentry; - if (!(debugfs_allow & DEBUGFS_ALLOW_API)) { - failed_creating(dentry); - return ERR_PTR(-EPERM); - } - inode = debugfs_get_inode(dentry->d_sb); if (unlikely(!inode)) { pr_err("out of free dentries, can not create automount '%s'\n", -- 2.47.3