From: Puranjay Mohan <puranjay@kernel.org>
To: bpf@vger.kernel.org
Cc: Puranjay Mohan <puranjay@kernel.org>,
Puranjay Mohan <puranjay12@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
kernel-team@meta.com
Subject: [PATCH bpf-next 2/4] bpf: arena: use kmalloc_nolock() in place of kvcalloc()
Date: Tue, 11 Nov 2025 16:34:20 +0000 [thread overview]
Message-ID: <20251111163424.16471-3-puranjay@kernel.org> (raw)
In-Reply-To: <20251111163424.16471-1-puranjay@kernel.org>
To make arena_alloc_pages() safe to be called from any context, replace
kvcalloc() with kmalloc_nolock() so as it doesn't sleep or take any
locks.
Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
---
kernel/bpf/arena.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/bpf/arena.c b/kernel/bpf/arena.c
index dd5100a2f93c..9d8a8eb447fe 100644
--- a/kernel/bpf/arena.c
+++ b/kernel/bpf/arena.c
@@ -506,8 +506,7 @@ static long arena_alloc_pages(struct bpf_arena *arena, long uaddr, long page_cnt
return 0;
}
- /* zeroing is needed, since alloc_pages_bulk() only fills in non-zero entries */
- pages = kvcalloc(page_cnt, sizeof(struct page *), GFP_KERNEL);
+ pages = kmalloc_nolock(page_cnt * sizeof(struct page *), __GFP_ZERO, -1);
if (!pages)
return 0;
@@ -546,12 +545,12 @@ static long arena_alloc_pages(struct bpf_arena *arena, long uaddr, long page_cnt
__free_page(pages[i]);
goto out;
}
- kvfree(pages);
+ kfree_nolock(pages);
return clear_lo32(arena->user_vm_start) + uaddr32;
out:
range_tree_set(&arena->rt, pgoff, page_cnt);
out_free_pages:
- kvfree(pages);
+ kfree_nolock(pages);
return 0;
}
--
2.47.3
next prev parent reply other threads:[~2025-11-11 16:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 16:34 [PATCH bpf-next 0/4] Remove KF_SLEEPABLE from arena kfuncs Puranjay Mohan
2025-11-11 16:34 ` [PATCH bpf-next 1/4] bpf: arena: populate vm_area without allocating memory Puranjay Mohan
2025-11-11 17:01 ` bot+bpf-ci
2025-11-13 4:49 ` kernel test robot
2025-11-13 4:51 ` kernel test robot
2025-11-13 4:52 ` kernel test robot
2025-11-11 16:34 ` Puranjay Mohan [this message]
2025-11-11 17:01 ` [PATCH bpf-next 2/4] bpf: arena: use kmalloc_nolock() in place of kvcalloc() bot+bpf-ci
2025-11-11 17:47 ` Alexei Starovoitov
2025-11-11 16:34 ` [PATCH bpf-next 3/4] bpf: arena: make arena kfuncs any context safe Puranjay Mohan
2025-11-11 17:01 ` bot+bpf-ci
2025-11-11 17:53 ` Alexei Starovoitov
2025-11-11 16:34 ` [PATCH bpf-next 4/4] selftests: bpf: test non-sleepable arena allocations Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111163424.16471-3-puranjay@kernel.org \
--to=puranjay@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox