From: Jakub Kicinski <kuba@kernel.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
netdev@vger.kernel.org, csmate@nop.hu, kerneljasonxing@gmail.com,
bjorn@kernel.org, sdf@fomichev.me, jonathan.lemon@gmail.com,
bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH net v3] xsk: avoid data corruption on cq descriptor number
Date: Mon, 17 Nov 2025 15:59:19 -0800 [thread overview]
Message-ID: <20251117155919.1834be7b@kernel.org> (raw)
In-Reply-To: <4cf22f51-c3d4-4c02-b5b6-0cb38985d0f8@suse.de>
On Mon, 17 Nov 2025 17:11:48 +0100 Fernando Fernandez Mancera wrote:
> >> Instead use the skb destructor_arg pointer along with pointer tagging.
> >> As pointers are always aligned to 8B, use the bottom bit to indicate
> >> whether this a single address or an allocated struct containing several
> >> addresses.
> >>
> >> Fixes: 30f241fcf52a ("xsk: Fix immature cq descriptor production")
> >> Closes: https://lore.kernel.org/netdev/0435b904-f44f-48f8-afb0-68868474bf1c@nop.hu/
> >> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> >> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
> >
> > Tested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> > Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> >
> > Fernando thanks for stepping in and providing this fix!
> > And thanks Jakub for ptr tagging trick.
> >
> > @BPF maintainers, please apply this patch.
This is just an skb patch, let's stick to net as previously requested
if that's okay with everyone.
> Thank you, please note that if rebasing is needed I can send a rebased
> version. Just let me know.
I think repost would be good. Get a fresh run thru CIs and re-raise it
to reviewers who may have started ignoring the thread.
prev parent reply other threads:[~2025-11-17 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 14:03 [PATCH net v3] xsk: avoid data corruption on cq descriptor number Fernando Fernandez Mancera
2025-10-31 9:51 ` Jason Xing
2025-10-31 10:05 ` Fernando Fernandez Mancera
2025-10-31 10:23 ` Jason Xing
2025-10-31 10:37 ` Fernando Fernandez Mancera
2025-11-17 16:08 ` Maciej Fijalkowski
2025-11-17 16:11 ` Fernando Fernandez Mancera
2025-11-17 23:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117155919.1834be7b@kernel.org \
--to=kuba@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=csmate@nop.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).