From: kernel test robot <lkp@intel.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Larysa Zaremba <larysa.zaremba@intel.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Wei Fang <wei.fang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Simon Horman <horms@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
"Bastien Curutchet (eBPF Foundation)"
<bastien.curutchet@bootlin.com>
Subject: Re: [Intel-wired-lan] [PATCH bpf v2 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz
Date: Fri, 13 Feb 2026 15:46:26 +0800 [thread overview]
Message-ID: <202602131552.b0xrTOY6-lkp@intel.com> (raw)
In-Reply-To: <20260212183328.1883148-6-larysa.zaremba@intel.com>
Hi Larysa,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf/master]
url: https://github.com/intel-lab-lkp/linux/commits/Larysa-Zaremba/xdp-use-modulo-operation-to-calculate-XDP-frag-tailroom/20260213-030652
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
patch link: https://lore.kernel.org/r/20260212183328.1883148-6-larysa.zaremba%40intel.com
patch subject: [Intel-wired-lan] [PATCH bpf v2 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20260213/202602131552.b0xrTOY6-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260213/202602131552.b0xrTOY6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602131552.b0xrTOY6-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_vsi_cfg_rxq':
>> drivers/net/ethernet/intel/ice/ice_base.c:662:13: warning: variable 'rx_buf_len' set but not used [-Wunused-but-set-variable]
662 | u32 rx_buf_len;
| ^~~~~~~~~~
vim +/rx_buf_len +662 drivers/net/ethernet/intel/ice/ice_base.c
8adfcfd6a2eedb Alexander Lobakin 2025-10-06 651
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 652 /**
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 653 * ice_vsi_cfg_rxq - Configure an Rx queue
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 654 * @ring: the ring being configured
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 655 *
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 656 * Return 0 on success and a negative value on error.
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 657 */
3e5fb691faee1d Maciej Fijalkowski 2024-01-23 658 static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring)
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 659 {
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 660 struct device *dev = ice_pf_to_dev(ring->vsi->back);
93f53db9f9dc4a Michal Kubiak 2025-09-25 661 u32 num_bufs = ICE_DESC_UNUSED(ring);
3a4f419f750946 Michal Kubiak 2025-09-25 @662 u32 rx_buf_len;
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 663 int err;
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 664
597b8af58bb2df Piotr Raczynski 2024-08-20 665 if (ring->vsi->type == ICE_VSI_PF || ring->vsi->type == ICE_VSI_SF) {
ebc33a3f8d0aed Maciej Fijalkowski 2024-07-26 666 ice_rx_xsk_pool(ring);
93f53db9f9dc4a Michal Kubiak 2025-09-25 667 err = ice_realloc_rx_xdp_bufs(ring, ring->xsk_pool);
93f53db9f9dc4a Michal Kubiak 2025-09-25 668 if (err)
93f53db9f9dc4a Michal Kubiak 2025-09-25 669 return err;
93f53db9f9dc4a Michal Kubiak 2025-09-25 670
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 671 if (ring->xsk_pool) {
6084262621449f Larysa Zaremba 2026-02-12 672 u32 frag_size =
6084262621449f Larysa Zaremba 2026-02-12 673 xsk_pool_get_rx_frag_step(ring->xsk_pool);
3a4f419f750946 Michal Kubiak 2025-09-25 674 rx_buf_len =
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 675 xsk_pool_get_rx_frame_size(ring->xsk_pool);
3de38c87174225 Maciej Fijalkowski 2024-01-24 676 err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev,
3de38c87174225 Maciej Fijalkowski 2024-01-24 677 ring->q_index,
3de38c87174225 Maciej Fijalkowski 2024-01-24 678 ring->q_vector->napi.napi_id,
6084262621449f Larysa Zaremba 2026-02-12 679 frag_size);
3de38c87174225 Maciej Fijalkowski 2024-01-24 680 if (err)
3de38c87174225 Maciej Fijalkowski 2024-01-24 681 return err;
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 682 err = xdp_rxq_info_reg_mem_model(&ring->xdp_rxq,
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 683 MEM_TYPE_XSK_BUFF_POOL,
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 684 NULL);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 685 if (err)
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 686 return err;
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 687 xsk_pool_set_rxq_info(ring->xsk_pool, &ring->xdp_rxq);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 688
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 689 dev_info(dev, "Registered XDP mem model MEM_TYPE_XSK_BUFF_POOL on Rx ring %d\n",
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 690 ring->q_index);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 691 } else {
8adfcfd6a2eedb Alexander Lobakin 2025-10-06 692 err = ice_rxq_pp_create(ring);
93f53db9f9dc4a Michal Kubiak 2025-09-25 693 if (err)
93f53db9f9dc4a Michal Kubiak 2025-09-25 694 return err;
93f53db9f9dc4a Michal Kubiak 2025-09-25 695
3de38c87174225 Maciej Fijalkowski 2024-01-24 696 err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev,
2fba7dc5157b6f Maciej Fijalkowski 2023-01-31 697 ring->q_index,
2fba7dc5157b6f Maciej Fijalkowski 2023-01-31 698 ring->q_vector->napi.napi_id,
6084262621449f Larysa Zaremba 2026-02-12 699 ring->truesize);
3de38c87174225 Maciej Fijalkowski 2024-01-24 700 if (err)
93f53db9f9dc4a Michal Kubiak 2025-09-25 701 goto err_destroy_fq;
973c22488e49c4 Larysa Zaremba 2026-02-12 702
93f53db9f9dc4a Michal Kubiak 2025-09-25 703 xdp_rxq_info_attach_page_pool(&ring->xdp_rxq,
93f53db9f9dc4a Michal Kubiak 2025-09-25 704 ring->pp);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 705 }
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 706 }
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 707
2fba7dc5157b6f Maciej Fijalkowski 2023-01-31 708 ring->xdp.data = NULL;
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 709 err = ice_setup_rx_ctx(ring);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 710 if (err) {
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 711 dev_err(dev, "ice_setup_rx_ctx failed for RxQ %d, err %d\n",
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 712 ring->q_index, err);
93f53db9f9dc4a Michal Kubiak 2025-09-25 713 goto err_destroy_fq;
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 714 }
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 715
1742b3d528690a Magnus Karlsson 2020-08-28 716 if (ring->xsk_pool) {
ed0907e3bdcfc7 Magnus Karlsson 2021-02-05 717 bool ok;
ed0907e3bdcfc7 Magnus Karlsson 2021-02-05 718
c4655761d3cf62 Magnus Karlsson 2020-08-28 719 if (!xsk_buff_can_alloc(ring->xsk_pool, num_bufs)) {
1742b3d528690a Magnus Karlsson 2020-08-28 720 dev_warn(dev, "XSK buffer pool does not provide enough addresses to fill %d buffers on Rx ring %d\n",
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 721 num_bufs, ring->q_index);
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 722 dev_warn(dev, "Change Rx ring/fill queue size to avoid performance issues\n");
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 723
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 724 return 0;
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 725 }
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 726
ebc33a3f8d0aed Maciej Fijalkowski 2024-07-26 727 ok = ice_alloc_rx_bufs_zc(ring, ring->xsk_pool, num_bufs);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 728 if (!ok) {
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 729 u16 pf_q = ring->vsi->rxq_map[ring->q_index];
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 730
1742b3d528690a Magnus Karlsson 2020-08-28 731 dev_info(dev, "Failed to allocate some buffers on XSK buffer pool enabled Rx ring %d (pf_q %d)\n",
2d4238f5569722 Krzysztof Kazimierczak 2019-11-04 732 ring->q_index, pf_q);
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 733 }
43c7f9198deb85 Krzysztof Kazimierczak 2020-11-20 734
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 735 return 0;
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 736 }
3f0d97cdfe6e90 Krzysztof Kazimierczak 2020-05-15 737
dc5e7a3513efcb Michal Kubiak 2025-05-14 738 if (ring->vsi->type == ICE_VSI_CTRL)
dc5e7a3513efcb Michal Kubiak 2025-05-14 739 ice_init_ctrl_rx_descs(ring, num_bufs);
dc5e7a3513efcb Michal Kubiak 2025-05-14 740 else
93f53db9f9dc4a Michal Kubiak 2025-09-25 741 err = ice_alloc_rx_bufs(ring, num_bufs);
93f53db9f9dc4a Michal Kubiak 2025-09-25 742
93f53db9f9dc4a Michal Kubiak 2025-09-25 743 if (err)
93f53db9f9dc4a Michal Kubiak 2025-09-25 744 goto err_destroy_fq;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 745
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 746 return 0;
93f53db9f9dc4a Michal Kubiak 2025-09-25 747
93f53db9f9dc4a Michal Kubiak 2025-09-25 748 err_destroy_fq:
8adfcfd6a2eedb Alexander Lobakin 2025-10-06 749 ice_rxq_pp_destroy(ring);
93f53db9f9dc4a Michal Kubiak 2025-09-25 750
93f53db9f9dc4a Michal Kubiak 2025-09-25 751 return err;
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 752 }
eff380aaffedb2 Anirudh Venkataramanan 2019-10-24 753
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-02-13 7:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 18:33 [PATCH bpf v2 0/9] Address XDP frags having negative tailroom Larysa Zaremba
2026-02-12 18:33 ` [PATCH bpf v2 1/9] xdp: use modulo operation to calculate XDP frag tailroom Larysa Zaremba
2026-02-13 20:34 ` Jakub Kicinski
2026-02-12 18:33 ` [PATCH bpf v2 2/9] xsk: introduce helper to determine rxq->frag_size Larysa Zaremba
2026-02-12 18:33 ` [PATCH bpf v2 3/9] ice: fix rxq info registering in mbuf packets Larysa Zaremba
2026-02-12 19:31 ` bot+bpf-ci
2026-02-12 18:33 ` [PATCH bpf v2 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz Larysa Zaremba
2026-02-13 3:57 ` Loktionov, Aleksandr
2026-02-13 8:41 ` Larysa Zaremba
2026-02-13 7:46 ` kernel test robot [this message]
2026-02-12 18:33 ` [PATCH bpf v2 5/9] i40e: fix registering XDP RxQ info Larysa Zaremba
2026-02-12 18:33 ` [PATCH bpf v2 6/9] i40e: use xdp.frame_sz as XDP RxQ info frag_size Larysa Zaremba
2026-02-13 4:04 ` Loktionov, Aleksandr
2026-02-13 8:58 ` Larysa Zaremba
2026-02-13 6:12 ` [Intel-wired-lan] " kernel test robot
2026-02-12 18:33 ` [PATCH bpf v2 7/9] idpf: use truesize " Larysa Zaremba
2026-02-16 10:46 ` Alexander Lobakin
2026-02-16 10:48 ` Alexander Lobakin
2026-02-16 14:01 ` Larysa Zaremba
2026-02-16 15:17 ` Alexander Lobakin
2026-02-12 18:33 ` [PATCH bpf v2 8/9] net: enetc: " Larysa Zaremba
2026-02-12 18:33 ` [PATCH bpf v2 9/9] xdp: produce a warning when calculated tailroom is negative Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602131552.b0xrTOY6-lkp@intel.com \
--to=lkp@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=bpf@vger.kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=martin.lau@linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox