From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA71538229B for ; Mon, 16 Mar 2026 11:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773660579; cv=none; b=Tv6vhckmgH5UaBHcnY/UHh/Y75RqnIKsUSkvQ6VzqBUEYckHio7kRM30JHIJTbD80y9JkXMZNHMlGQwPTu7VPmbzHLuMYYXpYszurvl5LESgzuG+D6Ryk2HMQCQ72SpvXP7FyFo8NcNUt4SNWgb8mFcIjrz8WsbEW/qZtcbo+6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773660579; c=relaxed/simple; bh=La0oxEXQHp19d2nfILBob+w4HOT1QdSwN6buq4oJMss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WiDAZslVF5Z8QgLcDnPNIcnUCqBHkYg/uA/e9NI4MPH/ePx+iI7DA8BK/6ZbREzI9hxg3Ql28R0EC0ytLMyPszT51u1CbVVzvGh4pwMrLZ32x50C5W0H0topPdQCXO/5bvvrrqlGlyGQojjmQNT64HK6N2DK36ujq9kMqUjfdSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GLtOWS+g; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GLtOWS+g" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8299f1ca894so2198627b3a.2 for ; Mon, 16 Mar 2026 04:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773660578; x=1774265378; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CbAiNsDyIMAUQsD2xc40hS2bONCwm72xxTw7O95hbw8=; b=GLtOWS+gxB0+/9R5HXYsnUJsT5nYFt+dfG5i1Ixsq/cSjtFZRhu0lZ7mDosAcpcwEc 5231JfNKHzMA9VHusbBs8EwmPkvZjAQfXOk2UEwZZ99qCxdpOasNw+bGKk+wg72W2msq Yjh09Z5M+rik487o1bbqbymlhAa/74WoLPFcE2Hx0NmBkQiaLLUacdG67U1uX58L3vIh HYDD0q+TSqOL+N28koFeB4ynQDVKZfl4gLQKYvFGJWSK1xn/KaxEESSVt7MhRt4FHWTI x5O+JV03Iv4AzDiiXTzk/B4LTNuh5tVlbr+PS946hkzWyINX6Btu9RGMX6AWTi2e+6uU +CAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773660578; x=1774265378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CbAiNsDyIMAUQsD2xc40hS2bONCwm72xxTw7O95hbw8=; b=lAgomr7s6qFiIC/4ijvGAQeU80uBkDAQx+4KamDrIKSxnBCglwpOhnXMpKME3G1zFb Hp+prrRkSAtQm8H7ln0i442fxb/74rakyiPOIWCAaAvmb0DrVoU4DhmYqm5TPfkCz4EH YFN4axcHS1n+BoDivIMVuI4QOU+FD9ikcOznDgmc5OgpoHUZPg0J5GGtOXnXNwmHcYFC R0Pm0LY1dbj/WI0M6PPPB5Km9tcqkWzA9LjL65ziLrEVGoWHU6TIFps1gC3BzORdQiZF 14zCRJ3F8tzoc5UcS996C0JZPmyTwO9QCwuluQyzrbzFAH6CJ5Vt5fR6ojlE87SuDo38 R5VQ== X-Gm-Message-State: AOJu0YxI6NMwt8GLIGU17myH1JzbHt3Bj3rb0WhAE9hciHlZDXF1GWlJ wmMIr85jAT5ZUVY2icYCe4B+5lvIPs4vBolF6B53zC7nvE1TdaW+dYYn X-Gm-Gg: ATEYQzx5LGlDTb7QcvHojy4uxijSAbyl21vaMpsAvxkHmHIv2AwwvuWyiYdgkDv1E0o 9dyeaRPOD6NLK6F3QRTP8DOMRh+vhYj44UcWspIA9YVGrUJ++AmVhXPAs8yIdTSS2+Qrd86txCI OgZm01VL6Ct4xoZ/oaVwxRTO36g/5xMOOMzQ0yM/wmX9qjdE85fZgcaIwV7IqsI2ay77ZAYFQ51 43XAWwPNG98gLpHnuzvP9rZwHt1Xt5rN8ueZ3fvIaxs8beRXBERUhIOvGPGUBfngRGoUpdOqUpc toUm5qHN2WB8hTiJK5C5M/Qhnj7REqExKyctOHF1zU/9ObJ6N/SrDrmU7Wj4DgJrvYLQ5mvguiC z2eow29GbgFt8cpjdoXxBKDcPeTs54/9NCWLVFdg91GuNazdbaOT4YqsiKHJtQNUE75k0LfM7IL udRuVtE65SAtZqtQLaTe36U6O4QU3+jfk1C/QSWeV8R9OPA/5rsKoZsKazMNWiJVo8Eg== X-Received: by 2002:a05:6a21:7a97:b0:398:78ca:c9d2 with SMTP id adf61e73a8af0-398eca24a5bmr11968023637.15.1773660578050; Mon, 16 Mar 2026 04:29:38 -0700 (PDT) Received: from localhost.localdomain ([116.128.244.171]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7401588ecesm4684940a12.32.2026.03.16.04.29.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 16 Mar 2026 04:29:37 -0700 (PDT) From: Chengkaitao To: martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, chengkaitao@kylinos.cn, linux-kselftest@vger.kernel.org Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v8 6/8] bpf: allow bpf_list_front/back result as the prev argument of bpf_list_add_impl Date: Mon, 16 Mar 2026 19:28:41 +0800 Message-ID: <20260316112843.78657-7-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260316112843.78657-1-pilgrimtao@gmail.com> References: <20260316112843.78657-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kaitao Cheng KF_ARG_PTR_TO_LIST_NODE normally requires an owning reference (PTR_TO_BTF_ID | MEM_ALLOC and ref_obj_id). For bpf_list_add_impl's third argument (prev), allow a non-owning reference with ref_obj_id==0 so that the result of bpf_list_front() or bpf_list_back() can be passed as the insertion point. When prev is such a non-owning ref, skip the MEM_ALLOC/ref_obj_id checks and jump to the shared list-node processing. Owning refs (e.g. from pop + refcount_acquire) still pass the existing checks and reach the same label. Signed-off-by: Kaitao Cheng --- kernel/bpf/verifier.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 98ddb370feb5..0a6f2e6a5d28 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -13737,6 +13737,14 @@ static int check_kfunc_args(struct bpf_verifier_env *env, struct bpf_kfunc_call_ return ret; break; case KF_ARG_PTR_TO_LIST_NODE: + if (meta->func_id == special_kfunc_list[KF_bpf_list_add_impl] + && i == 2 && type_is_non_owning_ref(reg->type) + && !reg->ref_obj_id) { + /* Allow bpf_list_front/back return value as + * list_add_impl's third arg (R3). + */ + goto check_ok; + } if (reg->type != (PTR_TO_BTF_ID | MEM_ALLOC)) { verbose(env, "arg#%d expected pointer to allocated object\n", i); return -EINVAL; @@ -13745,6 +13753,7 @@ static int check_kfunc_args(struct bpf_verifier_env *env, struct bpf_kfunc_call_ verbose(env, "allocated object must be referenced\n"); return -EINVAL; } +check_ok: ret = process_kf_arg_ptr_to_list_node(env, reg, regno, meta); if (ret < 0) return ret; -- 2.50.1 (Apple Git-155)