Re: [PATCH bpf-next v1 3/3] bpf: Remove gfp_flags plumbing from bpf_local_storage_update()

Amery Hung
2026-04-11T01:28:15Z

On Fri, Apr 10, 2026 at 6:19 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Fri, Apr 10, 2026 at 5:51 PM <bot+bpf-ci@kernel.org> wrote:
> >
> > > diff --git a/include/linux/bpf_local_storage.h b/include/linux/bpf_local_storage.h
> > > index dced54e9265f..9e4f5c45c974 100644
> > > --- a/include/linux/bpf_local_storage.h
> > > +++ b/include/linux/bpf_local_storage.h
> > > @@ -188,7 +188,7 @@ int bpf_selem_link_map(struct bpf_local_storage_map *smap,
> > >
> > > struct bpf_local_storage_elem *
> > > bpf_selem_alloc(struct bpf_local_storage_map *smap, void *owner, void *value,
> > > - bool swap_uptrs, gfp_t gfp_flags);
> > > + bool swap_uptrs);
> >
> > [ ... ]
> >
> > > @@ -196,12 +196,11 @@ void bpf_selem_free(struct bpf_local_storage_elem *selem,
> > > int
> > > bpf_local_storage_alloc(void *owner,
> > > struct bpf_local_storage_map *smap,
> > > - struct bpf_local_storage_elem *first_selem,
> > > - gfp_t gfp_flags);
> > > + struct bpf_local_storage_elem *first_selem);
> >
> > bpf_selem_alloc() now takes 4 arguments and bpf_local_storage_alloc()
> > takes 3, but bpf_sk_storage_clone_elem() and bpf_sk_storage_clone()
> > in net/core/bpf_sk_storage.c were not updated:
> >
> > net/core/bpf_sk_storage.c:bpf_sk_storage_clone_elem() {
> > copy_selem = bpf_selem_alloc(smap, newsk, NULL, false, GFP_ATOMIC);
> > }
> >
> > net/core/bpf_sk_storage.c:bpf_sk_storage_clone() {
> > ret = bpf_local_storage_alloc(newsk, smap, copy_selem, GFP_ATOMIC);
> > }
> >
> > Won't this break the build?
>
> Nice cleanup! Pls fix the build and respin right away.

Oh well. That's embarrassing... I made some changes to the last patch
at the last minute but didn't test it. Will respin right away.