Re: [PATCH bpf-next v1 3/3] bpf: Remove gfp_flags plumbing from bpf_local_storage_update()

bot+bpf-ci
2026-04-11T00:51:09Z

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

> diff --git a/include/linux/bpf_local_storage.h b/include/linux/bpf_local_storage.h
> index dced54e9265f..9e4f5c45c974 100644
> --- a/include/linux/bpf_local_storage.h
> +++ b/include/linux/bpf_local_storage.h
> @@ -188,7 +188,7 @@ int bpf_selem_link_map(struct bpf_local_storage_map *smap,
>
> struct bpf_local_storage_elem *
> bpf_selem_alloc(struct bpf_local_storage_map *smap, void *owner, void *value,
> - bool swap_uptrs, gfp_t gfp_flags);
> + bool swap_uptrs);

[ ... ]

> @@ -196,12 +196,11 @@ void bpf_selem_free(struct bpf_local_storage_elem *selem,
> int
> bpf_local_storage_alloc(void *owner,
> struct bpf_local_storage_map *smap,
> - struct bpf_local_storage_elem *first_selem,
> - gfp_t gfp_flags);
> + struct bpf_local_storage_elem *first_selem);

bpf_selem_alloc() now takes 4 arguments and bpf_local_storage_alloc()
takes 3, but bpf_sk_storage_clone_elem() and bpf_sk_storage_clone()
in net/core/bpf_sk_storage.c were not updated:

net/core/bpf_sk_storage.c:bpf_sk_storage_clone_elem() {
copy_selem = bpf_selem_alloc(smap, newsk, NULL, false, GFP_ATOMIC);
}

net/core/bpf_sk_storage.c:bpf_sk_storage_clone() {
ret = bpf_local_storage_alloc(newsk, smap, copy_selem, GFP_ATOMIC);
}

Won't this break the build?

---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24270284504