Re: [PATCH bpf-next v6 5/9] selftests/bpf: Add basic libarena scaffolding

bot+bpf-ci
2026-04-12T01:58:31Z

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

> diff --git a/tools/testing/selftests/bpf/libarena/include/common.h b/tools/testing/selftests/bpf/libarena/include/common.h
> new file mode 100644
> index 000000000000..5acf9b994943
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/libarena/include/common.h
> @@ -0,0 +1,67 @@
> +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause
> +/* Copyright (c) 2026 Meta Platforms, Inc. and affiliates. */
> +#pragma once
> +
> +#ifdef __BPF__
> +
> +#include <vmlinux.h>
> +
> +#include "bpf_experimental.h"

Is this include necessary? bpf_arena_spin_lock.h already pulls in
bpf_helpers.h, which provides bpf_stream_printk and the other
helpers used in this patch. Song Liu raised this in the v5 review
and it does not appear to have been addressed in v6.

https://lore.kernel.org/bpf/CAPhsuW6f58hx-2AW+X9kwT0oOsRZHW1RA7meWnMjuniJNoMgow@mail.gmail.com/

> +#include "bpf_arena_common.h"
> +#include "bpf_arena_spin_lock.h"

[ ... ]

---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24295891016