From: Feng Yang <yangfeng59949@163.com>
To: menglong.dong@linux.dev
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, eddyz87@gmail.com, jiayuan.chen@linux.dev,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
leon.hwang@linux.dev, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, martin.lau@linux.dev,
mattbobrowski@google.com, memxor@gmail.com, song@kernel.org,
yangfeng59949@163.com, yangfeng@kylinos.cn,
yonghong.song@linux.dev
Subject: Re: [PATCH v3 bpf-next 1/2] bpf: Fix Null-Pointer Dereference in kernel_clone() via BPF fmod_ret on security_task_alloc
Date: Mon, 13 Apr 2026 09:58:36 +0800 [thread overview]
Message-ID: <20260413015836.73506-1-yangfeng59949@163.com> (raw)
In-Reply-To: <4726660.LvFx2qVVIh@7950hx>
On Sun, 12 Apr 2026 11:39:53 +0800, Menglong Dong wrote:
> > static bool return_retval_range(struct bpf_verifier_env *env, struct bpf_retval_range *range)
> > {
> > @@ -18416,8 +18522,13 @@ static bool return_retval_range(struct bpf_verifier_env *env, struct bpf_retval_
> > *range = retval_range(0, 0);
> > break;
> > case BPF_TRACE_RAW_TP:
> > - case BPF_MODIFY_RETURN:
> > return false;
> > + case BPF_MODIFY_RETURN:
> > + if (!bpf_security_get_retval_range(env->prog, range))
> > + break;
> > + if (modify_return_get_retval_range(env->prog, range))
> > + return false;
> > + break;
>
> return false by default, as what we did in the previous logic?
>
> + case BPF_MODIFY_RETURN:
> + if (!bpf_security_get_retval_range(env->prog, range))
> + break;
> + if (!modify_return_get_retval_range(env->prog, range))
> + break;
> + return false;
>
Okay, thank you very much.
> > case BPF_TRACE_ITER:
next prev parent reply other threads:[~2026-04-13 1:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 16:35 [PATCH v3 bpf-next 0/2] bpf: Fix Null-Pointer Dereference in kernel_clone() via BPF fmod_ret on security_task_alloc Feng Yang
2026-04-11 16:35 ` [PATCH v3 bpf-next 1/2] " Feng Yang
2026-04-11 17:32 ` Alexei Starovoitov
2026-04-12 2:40 ` Feng Yang
2026-04-12 3:39 ` Menglong Dong
2026-04-13 1:58 ` Feng Yang [this message]
2026-04-21 9:18 ` Feng Yang
2026-04-11 16:35 ` [PATCH v3 bpf-next 2/2] selftests/bpf: Add selftests for verifying return values of fmod_ret Feng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413015836.73506-1-yangfeng59949@163.com \
--to=yangfeng59949@163.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jiayuan.chen@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=memxor@gmail.com \
--cc=menglong.dong@linux.dev \
--cc=song@kernel.org \
--cc=yangfeng@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox