Re: [PATCH bpf-next v2 9/9] bpf: Reuse MAX_BPF_FUNC_ARGS for maximum number of arguments

bot+bpf-ci
2026-04-22T06:12:16Z

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index 3cb6b9e70080..c8e387b0ce46 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1151,6 +1151,11 @@ struct bpf_prog_offload {
>
> /* The longest tracepoint has 12 args.
> * See include/trace/bpf_probe.h
> + *
> + * Also reuse this macro for maximum number of arguments a BPF function
> + * or a kfunc can have. Args 1-5 are passed in registers, args 6-12 via
> + * stack arg slots. The JIT may map some stack arg slots to registers based
> + * on the native calling convention (e.g., arg 6 to R9 on x86-64).
> */
> #define MAX_BPF_FUNC_ARGS 12

This isn't a bug, but the comment style doesn't match BPF subsystem
requirements. According to Documentation/process/maintainer-bpf.rst,
multi-line comments must have the opening /* on its own line, even when
surrounding code uses the old style. Should the comment be reformatted as:

/*
* The longest tracepoint has 12 args.
* See include/trace/bpf_probe.h
*
* Also reuse this macro for maximum number of arguments a BPF function
* or a kfunc can have. Args 1-5 are passed in registers, args 6-12 via
* stack arg slots. The JIT may map some stack arg slots to registers based
* on the native calling convention (e.g., arg 6 to R9 on x86-64).
*/

This style concern was raised by bot+bpf-ci@kernel.org in multiple patch
versions (v5, v6, v7, v8) but remains unaddressed:
https://lore.kernel.org/bpf/3bc734dfbeffc1c45e1c640be67af1824500aa1b8e04aee814e1942c1064cc96@mail.kernel.org/

---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24762480405