From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28A1B39B97B for ; Wed, 22 Apr 2026 18:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776883113; cv=none; b=pEe7cY5aP5lQPSZ4iGygGWfOMsvwqopMD5Myf2P4rvlLqk0FBwSVw5BtO2tYBawXzC6DTLTINa2/p/xYa9lX9/Jwb/g4OAf3G71hlDnHc80wYNqPUH+k98cOMNyvc0gz7bipTkJ3cF7n91sSCOomNk5dTWTIzU+KpDk2ZPWc2kY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776883113; c=relaxed/simple; bh=BcxRMIhkNuu2sSh+H+IQ0Fs35eUwSLc/sSU7chKO5WQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LPQqc8NPr7oq18YF/p+5pU88e4UTr7rPm1Xgp8bSS4Yw1Z1C2kqUqJ5LN3q31Z7993EBa3oALp+kh4ROO6S8PayMXy46Poau9GGcFcU9IJhGv9pA6wawnKNVH5mqxHoY0OSjcFR52WJrn8xvgcaTAA3H6JOPGKu0QTO9kl1w8Vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWkMvQ8C; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWkMvQ8C" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82f83bd32efso4560826b3a.2 for ; Wed, 22 Apr 2026 11:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776883111; x=1777487911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qo4HSW6PCAr8ze25Kke7fPDCSM3HoYXfLWuG/y7OdJQ=; b=QWkMvQ8CsCk2Ohv1EhpKt23jH010x0ySlnNxgEG2pSgH0e9O6tEIwPbYUfAIlZMZoh AH92GTnoR7zAJGgLBB3pqSJHIKyadDuQgSJ8wSX7Bz5Wd6YuHa0zUJJV98enMf6/mUBU tQIhPWAO8/UMtRGddzq5Xanme3nFl4wHKHr3JfvdpLRiXVnt3QkqAjChbk1iXxHK24/3 5w0Wpv57WO8Vl86eTX2rOSGWy3bW7P+f039Q8e9ugTLpzlPv4RDlKrhkOOPew+ADA3IZ VsxmgEQ75i6996oSV4B9pKSuMRH87x0pJbZ+gNfsJl5zKts35cskugDgTL5Lf86PfbZA PjNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776883111; x=1777487911; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qo4HSW6PCAr8ze25Kke7fPDCSM3HoYXfLWuG/y7OdJQ=; b=nju1xSWYqrLgvYzz8mkJnfz2Qc9z5tT9byRnuXAbjT6+D6PFCR5xP/nXQuGdc8++jv 6dZ6n9fbIW6hvJMIVWJgv8RVbRdXMGoPtuV1chnVsENvSYG02Ly4lDRvRKO3rrAu2XCm YGb1e+NgXcqY67aSwPzbVhs03lNATMMFUbpKz/IkKmLyhPZQkIgBEMVX8AOyKdV/SISm mhbebTfTUhKumdVS6SXqoNrho9/ZJ01rsPdJYIKIl7UCHCLcAcRejpB0awpx/COznlBs ZM5bloZ6ruaTf0DcvzRCRzODUNd+oQ4dZxGRp+tmAmn59AHt5hr2/xO7D8JRI0qCJdX7 SVEA== X-Forwarded-Encrypted: i=1; AFNElJ91bNihx3xgv+5armLXaU8iMUasCtpp+v/dqJMwJXn8Fj5mZaHr4t01O6BCKcjyE9NlU+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8j0BunmNjlpdUb9hORSDbLXVUVR3G/sF48wBnYQlkJttboG2A 7JrURc/NwI91Hm72kmGDH6T+PxrzdwKwrx3i0nmjQSREsfP3b5gp73Ar X-Gm-Gg: AeBDieshwJV7T1Fg7sPUABNUChqnkgE90epVcD49/bQA3sG75sNMWAYXzrloITzQd34 43WeRsSIwLJxwRdklKzNkTiA49UI8WPfYUXJoMZsTxGRK4ve4LyjoQfGNroOWjXKL3aEY+4Hk/B MCf2NWudeSGgJkG4JUEwXPrfoi5ui5Xcy6adTNmRdmzxNOP28e7adVW9VXthxEyJf8mNFIzY+7S 8C4Zr6mo+jW1RS51gkJpFg8Y+COPkRpJkOYaTi7faSUYC3kmAWJ1pwVEarlIlPwr9z+feJnaiIl SuqS0yYw7BH6ABauCxquAR9qkRYmUqJXvwZYuaqCVb+m8kCheTqeWHBlOjT9bdXO9nw9A7lEiMr BdtIUQ5nb6XKjEEzDuwSeG/uW1Zu8ZmOSWsX9fXLkGzOp7MXaZO2RGCcye3jZ/AtpdYIZmxr5RT jsyKj89Ht8V26LpQsDpEveyUwcX5tcVvsIgngEF9pB+MQ= X-Received: by 2002:a05:6a00:1acc:b0:82f:4a4d:377e with SMTP id d2e1a72fcca58-82f8c8c2f8fmr26121261b3a.28.1776883111412; Wed, 22 Apr 2026 11:38:31 -0700 (PDT) Received: from archlinux ([205.254.163.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe6439sm18034262b3a.41.2026.04.22.11.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 11:38:31 -0700 (PDT) From: Suchit Karunakaran To: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, memxor@gmail.com, shuah@kernel.org Cc: jolsa@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Suchit Karunakaran Subject: [PATCH] selftests/bpf: replace bpf_probe_read_kernel with direct access Date: Thu, 23 Apr 2026 00:07:57 +0530 Message-ID: <20260422183757.15069-1-suchitkarunakaran@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use direct field access instead of bpf_probe_read_kernel() for nlk->groups[0] and inode->i_ino, and clean up related code. Removes obsolete FIXME comments and unused variable. Signed-off-by: Suchit Karunakaran --- .../testing/selftests/bpf/progs/bpf_iter_netlink.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c b/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c index 00b2ceae81fb..5930bf8899d2 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_netlink.c @@ -17,7 +17,6 @@ int dump_netlink(struct bpf_iter__netlink *ctx) struct seq_file *seq = ctx->meta->seq; struct netlink_sock *nlk = ctx->sk; unsigned long group, ino; - struct inode *inode; struct socket *sk; struct sock *s; @@ -35,10 +34,7 @@ int dump_netlink(struct bpf_iter__netlink *ctx) if (!nlk->groups) { group = 0; } else { - /* FIXME: temporary use bpf_probe_read_kernel here, needs - * verifier support to do direct access. - */ - bpf_probe_read_kernel(&group, sizeof(group), &nlk->groups[0]); + group = nlk->groups[0]; } BPF_SEQ_PRINTF(seq, "%-10u %08x %-8d %-8d %-5d %-8d ", nlk->portid, (u32)group, @@ -50,12 +46,7 @@ int dump_netlink(struct bpf_iter__netlink *ctx) if (!sk) { ino = 0; } else { - /* FIXME: container_of inside SOCK_INODE has a forced - * type conversion, and direct access cannot be used - * with current verifier. - */ - inode = SOCK_INODE(sk); - bpf_probe_read_kernel(&ino, sizeof(ino), &inode->i_ino); + ino = SOCK_INODE(sk)->i_ino; } BPF_SEQ_PRINTF(seq, "%-8u %-8lu\n", s->sk_drops.counter, ino); -- 2.53.0