From: Yonghong Song <yonghong.song@linux.dev>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"Jose E . Marchesi" <jose.marchesi@oracle.com>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>
Subject: [PATCH bpf-next v3 2/9] bpf: Fix tail_call_reachable leak
Date: Wed, 22 Apr 2026 20:34:35 -0700 [thread overview]
Message-ID: <20260423033435.2538013-1-yonghong.song@linux.dev> (raw)
In-Reply-To: <20260423033425.2536883-1-yonghong.song@linux.dev>
In check_max_stack_depth_subprog(), the local variable
tail_call_reachable is set when entering a callee that has a tail
call, but never reset when popping back to the parent. This causes
the flag to leak across sibling subprogs in the DFS traversal.
This results in unnecessary JIT overhead: the JIT emits tail call
counter preservation code for subprogs that can never be reached
via a tail call path.
Fix this by resetting tail_call_reachable to the parent's actual
per-subprog flag when popping a frame. If the parent was already
marked tail_call_reachable by a previous sibling's traversal, the
local variable stays true. Otherwise it resets to false, so
subsequent siblings start with a clean state.
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
---
kernel/bpf/verifier.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 6118743d87e6..26b6cdfd8613 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -5490,6 +5490,9 @@ static int check_max_stack_depth_subprog(struct bpf_verifier_env *env, int idx,
frame = dinfo[idx].frame;
i = dinfo[idx].ret_insn;
+ /* reset tail_call_reachable to the parent's actual state */
+ tail_call_reachable = subprog[idx].tail_call_reachable;
+
goto continue_func;
}
--
2.52.0
next prev parent reply other threads:[~2026-04-23 3:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 3:34 [PATCH bpf-next v3 0/9] bpf: Prepare to support stack arguments Yonghong Song
2026-04-23 3:34 ` [PATCH bpf-next v3 1/9] bpf: Remove unused parameter from check_map_kptr_access() Yonghong Song
2026-04-23 3:34 ` Yonghong Song [this message]
2026-04-23 3:34 ` [PATCH bpf-next v3 3/9] bpf: Remove WARN_ON_ONCE in check_kfunc_mem_size_reg() Yonghong Song
2026-04-23 3:34 ` [PATCH bpf-next v3 4/9] bpf: Refactor to avoid redundant calculation of bpf_reg_state Yonghong Song
2026-04-23 4:22 ` bot+bpf-ci
2026-04-23 3:34 ` [PATCH bpf-next v3 5/9] bpf: Refactor to handle memory and size together Yonghong Song
2026-04-23 3:34 ` [PATCH bpf-next v3 6/9] bpf: Rename existing argno to arg Yonghong Song
2026-04-23 3:35 ` [PATCH bpf-next v3 7/9] bpf: Prepare verifier logs for upcoming kfunc stack arguments Yonghong Song
2026-04-23 3:35 ` [PATCH bpf-next v3 8/9] bpf: Introduce bpf register BPF_REG_PARAMS Yonghong Song
2026-04-23 3:35 ` [PATCH bpf-next v3 9/9] bpf: Reuse MAX_BPF_FUNC_ARGS for maximum number of arguments Yonghong Song
2026-04-23 4:11 ` bot+bpf-ci
2026-04-23 15:10 ` [PATCH bpf-next v3 0/9] bpf: Prepare to support stack arguments patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423033435.2538013-1-yonghong.song@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jose.marchesi@oracle.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox