From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 988D439FCAF for ; Tue, 28 Apr 2026 23:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777419958; cv=none; b=lBkz6uAjaFyeKPG9NmAU0eohABavwHTVk0g8FSl9l5SgQtAGJdeNPVi5a5QRqj5eJCqz63jMyikpsz5pqYcDHHMcu/WFlHp1Q7vhjxdKJmqIIs+55RVVdyAWGPFFNAFjL1MgoXOI8VIw7VK/Py42sHnbdkj88ulwQBFWfDiB848= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777419958; c=relaxed/simple; bh=K+vaP2nMwIyYoWLRAJ8KOc+0zXq9dzqeDfUA1fjaXMI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RfAD89pj/MdrqyYDYmkZBjSOgRMk1mBjw9SStKDGrV6H290GZBPLV8JNgI2BCGiVqcWgy2gMrMyO//mh/k/ikyvXsGMWZBV6SXFauGFRhaxgKNJC2i+mkhza8wq/Qn1OiZ7o00f7nQrn/m6Qjb1GNCaOvyt8O/4iwMjvS/1sMK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=e8Iu+QOD; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="e8Iu+QOD" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4890098abbaso94503525e9.0 for ; Tue, 28 Apr 2026 16:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1777419955; x=1778024755; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9hjnI5sv67kd9Z2OrkU0HujdVy68CkTBm54JLMxtNMI=; b=e8Iu+QODV8uRdOwMSmRvfGkMPO+3CLU0MsuceJg5CkPdvfWZ57udb6rBfmhS/wfvPZ +KAM2XGLc93nDyU5lTh+0icfnITXy5TqICom7agUl5wc77bPXzJbiCfzeWSP/0Za2IgE ucrEKYqx5niEaz6auGDFIKgzFAaqIjS+Eb4a7lfzua++S6BrlGuAdSHomhwIFFgRtAl8 aBdTIneRvTV/utVZ9+gckC1gFx+Ig6YzXKBxlUTMIxwvEvIGtSKnI8m8BaDO1L00WtQ1 SJtnYTW5pTo9ppX0QogskBGpDw9HApyIdARss/b1LLJBuiOz2UQcgZG23STBMoNPo7v5 bgjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777419955; x=1778024755; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9hjnI5sv67kd9Z2OrkU0HujdVy68CkTBm54JLMxtNMI=; b=fvWTXRrk103eL1b6xH8YwhLwWN2CjLa0d+l1Uxz6X48mDhh0G/RzYn78zNqz/9Z12u o7GL7nictTrLmD2M36BgXD/vEEXunNmUtwmo+jiev/CQ4gXFbGhsxaUviK2hC5Y2UVmt T7ejdwIfXCZW6mNVNyaTzxyWfOZf6W9syfkmJpSrXLIq/sxTjv6o7R+6jBAIZZkeCzMy BFxguzy7i2Td7/GGbIXZpswpy8Kyp8bAfFKKBpQgwvNi3KFdidULq9wAIKf/1XFG+01M iLI2zP+S0rpUFV8SI6klYlZPU7yX2vgC+X1jrbb3mv1wrAm4WxIfoeFwt08+yHTFYkb0 jKoA== X-Gm-Message-State: AOJu0YznkOOMJ5/YGjXUfZEr1SEc8X1E2DS92FGFHFoASm8CnTed5rp9 whE/yREURVC3ogbp0yDQhjZgIKbNuJWZCSG+T+eF85QlxLnle/9WSnxeF2MoZnyxYxg= X-Gm-Gg: AeBDievcz7OKS5owSbd4ZNZEhqbtf3NsU2SZc+8ZliOv5zt3mzFI8K1ZLnh7awfo+7O ZhxQPOZv/s7ATOWzOm6swwbbg+oq/IPX86F47k6+WkkDjYuB7OQBWsnXikKSgBTk3ujHk06cf9Q vrZNVwL4UFvYtE2IFE20gL7n8kaz+yHWDRFKIelYfwx7r24bNCP+VPfM86Qr/oyEgdiC+gZGsOz HL815xWy/5DmpUkVZlcWP3Kuno5AO7nJqyAyFgWP9kxHBWQxz1wFDlFjM9EOC9OirfMgMjJTUCx 7AzDwz8ocUw3L4wK54ME5eobm1taAagGcM06XlPSVw4bN3yfY0ff9TQ2UY7ibQcsAJXXXw0+/an 6xmHnjU29Fr04W83L/zkQpbpR+5nB+zH1DfZspQwFrfvwXjI6ebziYqSAFjpHnyj4O1wf9VHqaY 6oVW4VZ+vavgyhUke4HOSwz7Or X-Received: by 2002:a05:600c:8595:b0:489:6c22:e081 with SMTP id 5b1f17b1804b1-48a7b4d5292mr19685905e9.0.1777419955103; Tue, 28 Apr 2026 16:45:55 -0700 (PDT) Received: from localhost ([2804:7f0:b765:105d:ce28:aaff:fe86:149c]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-573b6d87e40sm207420e0c.12.2026.04.28.16.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 16:45:53 -0700 (PDT) From: =?utf-8?q?Ricardo_B=2E_Marli=C3=A8re?= Date: Tue, 28 Apr 2026 20:45:10 -0300 Subject: [PATCH bpf-next v8 09/11] selftests/bpf: Tolerate benchmark build failures Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260428-selftests-bpf_misconfig-v8-9-bf02cf97dbcb@suse.com> References: <20260428-selftests-bpf_misconfig-v8-0-bf02cf97dbcb@suse.com> In-Reply-To: <20260428-selftests-bpf_misconfig-v8-0-bf02cf97dbcb@suse.com> To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Alan Maguire , "Ricardo B. Marliere" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openssh-sha256; t=1777419912; l=2217; i=rbm@suse.com; h=from:subject:message-id; bh=K+vaP2nMwIyYoWLRAJ8KOc+0zXq9dzqeDfUA1fjaXMI=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgguRCc5X8/UX9M40lkMnr//aFGOhce x5ezt8MFNUFlqYAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QCLRSJzLFmbxcd8Oti89XkYLPxUKPMs9XiDZ2GentAu+0JH4vQWhDEuNUNurJmaqlvTu7XnhPDs iNsBf19PdGQ4= X-Developer-Key: i=rbm@suse.com; a=openssh; fpr=SHA256:pzhe0fJpYLz+3cZ33FFPhIfaUElk9CXPFFXmalIH+1g Benchmark objects depend on skeletons that may be missing when some BPF programs fail to build. In that case, benchmark object compilation or final bench linking should not abort the full selftests/bpf build. Keep both steps non-fatal, emit SKIP-BENCH or SKIP-LINK, and remove failed outputs so stale objects or binaries are not reused by later incremental builds. Note that because bench.c statically references every benchmark via extern symbols, partial linking is not possible: if any single benchmark object fails, the entire bench binary is skipped. This is by design -- the error handler catches all compilation failures including genuine ones, but those are caught by full-config CI runs. Signed-off-by: Ricardo B. Marlière --- tools/testing/selftests/bpf/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index 9a5177455f0a..461e2d9416fc 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -939,7 +939,8 @@ $(OUTPUT)/test_cpp: test_cpp.cpp $(OUTPUT)/test_core_extern.skel.h $(BPFOBJ) # Benchmark runner $(OUTPUT)/bench_%.o: benchs/bench_%.c bench.h $(BPFOBJ) $(call msg,CC,,$@) - $(Q)$(CC) $(CFLAGS) -O2 -c $(filter %.c,$^) $(LDLIBS) -o $@ + $(Q)$(CC) $(CFLAGS) -O2 -c $(filter %.c,$^) $(LDLIBS) -o $@ $(if $(PERMISSIVE),|| \ + ($(RM) $@; printf ' %-12s %s\n' 'SKIP-BENCH' '$(notdir $@)' 1>&2)) $(OUTPUT)/bench_rename.o: $(OUTPUT)/test_overhead.skel.h $(OUTPUT)/bench_trigger.o: $(OUTPUT)/trigger_bench.skel.h $(OUTPUT)/bench_ringbufs.o: $(OUTPUT)/ringbuf_bench.skel.h \ @@ -982,7 +983,8 @@ $(OUTPUT)/bench: $(OUTPUT)/bench.o \ $(OUTPUT)/usdt_2.o \ # $(call msg,BINARY,,$@) - $(Q)$(CC) $(CFLAGS) $(LDFLAGS) $(filter %.a %.o,$^) $(LDLIBS) -o $@ + $(Q)$(CC) $(CFLAGS) $(LDFLAGS) $(filter %.a %.o,$(if $(PERMISSIVE),$(wildcard $^),$^)) $(LDLIBS) -o $@ $(if $(PERMISSIVE),|| \ + ($(RM) $@; printf ' %-12s %s\n' 'SKIP-LINK' '$(notdir $@) (some benchmarks may have been skipped)' 1>&2)) # This works around GCC warning about snprintf truncating strings like: # -- 2.54.0