Re: [PATCH net-next 11/11] selftests: drv-net: add netkit devmem tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added executable test script `nk_devmem.py` is not added to `TEST_PROGS` in the subsystem Makefile.
--

commit 052df7b2cdca71035e04527f52dbd4dd5e53cf60
Author: Bobby Eshleman <bobbyeshleman@meta.com>

selftests: drv-net: add netkit devmem tests

This commit adds a new python script with four tests for TCP devmem through
a netkit device. The tests duplicate the original devmem tests with adjusted
parameters and use a configuration environment to set up the BPF redirect
program on the primary netkit interface.

> diff --git a/tools/testing/selftests/drivers/net/hw/nk_devmem.py b/tools/testing/selftests/drivers/net/hw/nk_devmem.py
> new file mode 100755
> index 000000000000..c069d525798b
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/hw/nk_devmem.py

Does the absence of a Makefile update introduce a regression during test
installation?

It appears this new executable test script is not being added to TEST_PROGS
in the subsystem Makefile. When tests are run from an installed location
after a build, omitting the script from the Makefile can lead to a missing
file error.

Could the new file be added to TEST_PROGS so it is properly tracked and
installed by the build system?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260428-tcp-dm-netkit-v1-0-719280eba4d2@meta.com?part=11