Re: [PATCH bpf-next v10 07/11] selftests/bpf: Skip tests whose objects were not built

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unbuilt tests are completely omitted from the output of `--list` (`-l`) and `--count` modes, undermining the goal of keeping them visible in CI.
--

commit 16f4b9e5278a9d4b4fc723587353c47ffcf761e1
Author: Ricardo B. Marlière <rbm@suse.com>

selftests/bpf: Skip tests whose objects were not built

When both run_test and run_serial_test are NULL (because the corresponding
.test.o was not compiled), mark the test as not built instead of fatally
aborting.

> diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
> index cc14b13e23fe1..7ba82974ee784 100644
> --- a/tools/testing/selftests/bpf/test_progs.c
> +++ b/tools/testing/selftests/bpf/test_progs.c
[ ... ]
> @@ -2106,9 +2134,18 @@ int main(int argc, char **argv)
>  
>  	for (i = 0; i < prog_test_cnt; i++) {
>  		struct prog_test_def *test = &prog_test_defs[i];
> +		struct test_state *state = &test_states[i];
>  
> -		if (!test->should_run)
> +		if (!test->should_run) {
> +			if (test->not_built && test->selected &&
> +			    !env.get_test_cnt && !env.list_test_names) {
> +				state->tested = true;
> +				state->skip_cnt = 1;
> +				env.not_built_cnt++;
> +				print_test_result(test, state);
> +			}
>  			continue;

Since should_run is set to false for unbuilt tests, will the unconditional
continue here completely omit unbuilt tests from the output of --list (-l) and
--count modes?

If these tests are omitted during list mode, CI systems that use test_progs -l
to discover, chunk, and distribute tests across parallel jobs won't be aware
of them.

Could this lead to the unbuilt tests quietly disappearing from final CI
results, undermining the goal of keeping them visible?

> +		}
>  
>  		if (env.get_test_cnt) {
>  			env.succ_cnt++;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260430-selftests-bpf_misconfig-v10-0-cd302a31af16@suse.com?part=7