Re: [PATCH net-next v2 6/6] selftests: drv-net: add netkit devmem tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The path to the 'ncdevmem' binary is incorrectly constructed using string concatenation instead of `os.path.join()`, which breaks script execution when run without a path prefix.
--

commit 39598108535535c8a8daee8f3c206760a98e0c68
Author: Bobby Eshleman <bobbyeshleman@meta.com>

selftests: drv-net: add netkit devmem tests

This commit adds a new Python script to test TCP devmem through a netkit
device. It duplicates the original devmem tests with adjusted parameters
for the netkit environment.

> diff --git a/tools/testing/selftests/drivers/net/hw/nk_devmem.py b/tools/testing/selftests/drivers/net/hw/nk_devmem.py
> new file mode 100755
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/hw/nk_devmem.py

[ ... ]

> +def main() -> None:
> +    with NetDrvContEnv(__file__, rxqueues=2, primary_rx_redirect=True) as cfg:
> +        setup_test(cfg, path.abspath(path.dirname(__file__) + "/ncdevmem"))

Will this path concatenation fail if the script is executed manually without
a directory prefix?

If __file__ evaluates to just the filename without a directory,
path.dirname(__file__) returns an empty string. Concatenating an empty string
with "/ncdevmem" results in the absolute path "/ncdevmem".

When this happens, the script will attempt to execute the binary from the
system root directory instead of the test directory.

Would it be safer to use os.path.join(path.dirname(__file__), "ncdevmem")
here to handle empty directory strings correctly?

> +        ksft_run([check_nk_rx, check_nk_tx, check_nk_tx_chunks, check_nk_rx_hds],
> +                 args=(cfg,))
> +    ksft_exit()

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260504-tcp-dm-netkit-v2-0-56d52ac72fd4@meta.com?part=6