Re: [PATCH v2 1/4] psi: add psi_group_flush_stats() function

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build failure when CONFIG_CGROUPS is enabled but CONFIG_PSI is disabled.
--

commit 3c39f362bc58a25b857026542cbe7d4bb70721fd
Author: Vernon Yang <yanglincheng@kylinos.cn>

psi: add psi_group_flush_stats() function

This commit adds the psi_group_flush_stats() function to prepare for
the subsequent mthp_ext ebpf program.

> diff --git a/include/linux/psi.h b/include/linux/psi.h
> index e0745873e3f26..7b4fd8190810f 100644
> --- a/include/linux/psi.h
> +++ b/include/linux/psi.h
> @@ -22,6 +22,7 @@ void psi_init(void);
>  void psi_memstall_enter(unsigned long *flags);
>  void psi_memstall_leave(unsigned long *flags);
>  
> +void psi_group_flush_stats(struct psi_group *group);

Will this cause a build failure if the kernel is configured with
CONFIG_CGROUPS=y but CONFIG_PSI=n?

Because there is no fallback stub or empty definition for
psi_group_flush_stats() when CONFIG_PSI is disabled, callers added in
subsequent patches under CONFIG_CGROUPS might face undefined references.

Would it make sense to add an empty inline stub in the #else branch
for CONFIG_PSI?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508150055.680136-1-vernon2gm@gmail.com?part=1