From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5303730BB8A; Fri, 15 May 2026 00:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778806458; cv=none; b=Al2WROWzOFxGNXBZZYIVK4r+Q8WwO1GnPDZrogNrg62uVN2wiR4ODwChesQOq/v5wEBtUhu52QTmMUw2t1toQCTWbcNxCbYoQGFhDJ4N9siBCuFANBTyMeAf9mJ21yAYnQYBwH2GbJSB29rMEatQa/VPTCFPvyUQPM5EBTcUK34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778806458; c=relaxed/simple; bh=wZOLjfrjt2pvr5Lt1w+KjqrTR1B3pH1+E6zYCPeGKk8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J10vNoElfWJtjTadTMkU2yfKo1995E4o5p0+D4KsHcrJqzD7ziwiMmHR7qnJb/064xcz1K4zAU1GX6q40ORd+lH3pYWANI2Y3ONUBX3NuSWG79xtyWT/QXDLS1rmg/nyCEn8YdJ+yWWn5gL18YFT++wMiJEnUwzux0/epIOOxBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VpRkYZIP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VpRkYZIP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4946AC2BCB3; Fri, 15 May 2026 00:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778806457; bh=wZOLjfrjt2pvr5Lt1w+KjqrTR1B3pH1+E6zYCPeGKk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VpRkYZIPeoMXJ893zZlQUcewLMttlR03IiU14nUrnaH+GD9gaeqH6PIv3glw6Ttg+ 2qTeAoKXKAj3OHYTIKGWbBouoel60ZRRUdOMe5vkPuYED/tjFyHNUgYBnqc2MMXeYM 8pCCMDpPP6r42+TfL/AM8mTBA1IoIM9AOeEI82fiFmbZtQdeXDtJQasaKT29zaexvo 9rlBO3Jlopf2ptIqzxcwC6wO2KhvjKLxaJ44sN4keHg9757FZHM3H0lz96+2FYz5M0 OAs8N+7X51R/U5JOtFaKi07QwolGG+hzRtChKa+ithDBP072zapImomTfHSVi6Ljd/ Aqs16oiQ3NI8Q== Date: Thu, 14 May 2026 17:54:16 -0700 From: Jakub Kicinski To: Maciej Fijalkowski Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, magnus.karlsson@intel.com, stfomichev@gmail.com, pabeni@redhat.com, horms@kernel.org, bjorn@kernel.org, lorenzo@kernel.org, hawk@kernel.org, toke@redhat.com Subject: Re: [PATCH RFC net-next 0/4] xdp: reuse generic skb XDP handling for veth Message-ID: <20260514175416.50b7eae3@kernel.org> In-Reply-To: <20260509084858.773921-1-maciej.fijalkowski@intel.com> References: <20260509084858.773921-1-maciej.fijalkowski@intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 9 May 2026 10:48:54 +0200 Maciej Fijalkowski wrote: > - the INDIRECT_CALL for taking the COW path; I wanted to preserve > existing behavior, but is it really needed or maybe it would be > possible to come up with conditions that would cover both generic > XDP path and veth? Yes, the conditions are almost identical. I think we can OR them all together (removing dups like skb_head_is_locked() + cloned; skb_shinfo(skb)->nr_frags and skb_is_nonlinear()