Re: [PATCH bpf-next v7 4/7] selftests/bpf: add bpf_icmp_send kfunc cgroup_skb tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment does not follow the required BPF subsystem style.
--

commit 67ff0f6d65a210627d2fdadf8ec80c32d95d6a59
Author: Mahe Tardy <mahe.tardy@gmail.com>

selftests/bpf: add bpf_icmp_send kfunc cgroup_skb tests

This commit adds a test for the bpf_icmp_send kfunc using a cgroup_skb
egress program. It verifies that ICMP unreach messages are correctly sent
back to the client and read from the socket's error queue.

> diff --git a/tools/testing/selftests/bpf/prog_tests/icmp_send_kfunc.c b/tools/testing/selftests/bpf/prog_tests/icmp_send_kfunc.c
> new file mode 100644
> index 0000000000000..0dc6b6ceafb4a
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/icmp_send_kfunc.c

[ ... ]

> @@ -126,10 +126,10 @@ void test_icmp_send_unreach_cgroup(void)
> +	for (int code = 0; code <= NR_ICMP_UNREACH; code++) {
> +		/* The TCP stack reacts differently when asking for
> +		 * fragmentation, let's ignore it for now.
> +		 */

[Severity: Low]
This isn't a bug, but does this multi-line comment follow the preferred
kernel comment style for the BPF subsystem? The style guidelines require
the opening /* to be on its own line.

> +		if (code == ICMP_FRAG_NEEDED)
> +			continue;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526153708.279717-1-mahe.tardy@gmail.com?part=4