Re: [PATCH bpf-next 3/3] selftests/bpf: Adjust fexit_bpf2bpf ctx layout for llvm23 true signature

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] The modified multi-line comment retains text on the same line as the opening `/*`, violating the BPF subsystem comment style guidelines.
--

commit 895b9c1828c7212301bcd7381a175a6b61a7df58
Author: Yonghong Song <yonghong.song@linux.dev>

selftests/bpf: Adjust fexit_bpf2bpf ctx layout for llvm23 true signature

This commit adjusts the fexit context layout for test_pkt_access_subprog2()
to accommodate differences in how llvm23 records the function signature in
BTF. It selects the matching arguments struct based on the compiler version
to ensure compatibility.

> diff --git a/tools/testing/selftests/bpf/progs/fexit_bpf2bpf.c b/tools/testing/selftests/bpf/progs/fexit_bpf2bpf.c
> --- a/tools/testing/selftests/bpf/progs/fexit_bpf2bpf.c
> +++ b/tools/testing/selftests/bpf/progs/fexit_bpf2bpf.c
> @@ -53,14 +53,23 @@ int BPF_PROG(test_subprog1, struct sk_buff *skb, int ret)
>   *   r0 = *(u32 *)(r1 + 0)
>   *   w0 <<= 1
>   *   exit
> - * In such case the verifier falls back to conservative and
> + * Before llvm23, in such case the verifier falls back to conservative and
>   * tracing program can access arguments and return value as u64
> - * instead of accurate types.
> + * instead of accurate types. With llvm23, the true signature
> + *   int test_pkt_access_subprog2(volatile struct __sk_buff *skb)
> + * is available in btf.
>   */

[Severity: Low]
This is a pre-existing issue, but since this multi-line comment block is
being modified, could we update its opening to comply with the current
BPF subsystem style rules?

The guidelines prefer the opening /* to be on its own line, rather than
keeping text on the same line.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609163947.1717694-1-yonghong.song@linux.dev?part=3