BPF List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Andrii Nakryiko <andrii@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	Jiri Olsa <jolsa@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Kuniyuki Iwashima <kuni1840@gmail.com>,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next/net 0/5] bpf: Support RX/TX HW timestamp proxy.
Date: Sat, 13 Jun 2026 15:47:50 -0700	[thread overview]
Message-ID: <20260613154750.0a2355a4@kernel.org> (raw)
In-Reply-To: <CAAVpQUBP_21b5MB8MS-wFwg9BUdcgMoNxi8s479YQHH9g5ahCw@mail.gmail.com>

On Sat, 13 Jun 2026 14:43:46 -0700 Kuniyuki Iwashima wrote:
> On Sat, Jun 13, 2026 at 10:20 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Sat, 13 Jun 2026 00:59:57 +0000 Kuniyuki Iwashima wrote:  
> > > When standard socket applications are run on these hosts,
> > > a userspace proxy is required to mediate traffic between the
> > > hardware and the applications.
> > >
> > >             +---------+                 +----------------------+
> > >             |  proxy  |                 |  socket application  |
> > >             +---------+                 +----------------------+
> > >               ^     ^                               ^
> > >   userspace   |     |                               |
> > >   -----------| |-----------------------------------------------
> > >              | |    |    +---------------------+    | skb
> > >              | |    `--->|  virtual interface  |<---'
> > >   kernel     | |   skb   +---------------------+
> > >   -----------| |-----------------------------------------------
> > >               |
> > >               v
> > >        +------------+
> > >        |  hardware  |
> > >        +------------+  
> >
> > The first patch looks kinda nonsensical but then I saw this diagram.
> > Looks like you're vibe coding an integration that makes it easier to
> > treat netdev as a slow path for a user networking stack.
> > Please tell me if I'm missing anything otherwise add my nack if you
> > repost.  
> 
> Hmm, what would be a better way to tell users that HW TS is
> available on tunnel devices ?
> 
> Other options were 1) add attribute to tie the tunnel to a physical
> device and use its ndo_hwtstamp_set/get, or 2) add bpf retval
> hook in the path like update_socket_protocol().

Can you explain the use case for HW timestamps on tunnels?
I see you have some diagrams in patches 3 and 4 but the motivation
isn't really explained, and we have 250 patches in the queue still.
Not much time to play detective right now :/

> Or do you think applications should handle ENOTSUP by ioctl
> as soft error and always set SOF_TIMESTAMPING_XXX_HARDWARE
> since the underlying physical device may support it ?

And explain the deployment model and API semantics you have in mind.

> Anyway, I'm happy to drop patch 1 for now and explore options.

Not patch 1, all of it. I get the feeling y'all are sitting on a pile
of Swift related code that needs to be made upstreamable. Odd series
like this make me think it's never going to happen.

> (Believe it or not, I haven't let AI write code because I don't
>  want AI to take over the most fun part.)

  reply	other threads:[~2026-06-13 22:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13  0:59 [PATCH v2 bpf-next/net 0/5] bpf: Support RX/TX HW timestamp proxy Kuniyuki Iwashima
2026-06-13  0:59 ` [PATCH v2 bpf-next/net 1/5] ethtool: Introduce ETHTOOL_MSG_TSINFO_SET for virtual interfaces Kuniyuki Iwashima
2026-06-13  1:21   ` sashiko-bot
2026-06-13  2:29   ` Stanislav Fomichev
2026-06-13  3:43     ` Kuniyuki Iwashima
2026-06-13  0:59 ` [PATCH v2 bpf-next/net 2/5] bpf: Rename bpf_kfunc_set_tcp_reqsk to bpf_kfunc_set_sched_cls Kuniyuki Iwashima
2026-06-13  1:00 ` [PATCH v2 bpf-next/net 3/5] bpf: Add bpf_skb_set_hwtstamp() Kuniyuki Iwashima
2026-06-13  1:12   ` sashiko-bot
2026-06-13 22:01     ` Kuniyuki Iwashima
2026-06-13  1:00 ` [PATCH v2 bpf-next/net 4/5] bpf: Add kfunc to proxy TX HW Timestamp Kuniyuki Iwashima
2026-06-13  1:20   ` sashiko-bot
2026-06-13 22:03     ` Kuniyuki Iwashima
2026-06-13  1:00 ` [PATCH v2 bpf-next/net 5/5] selftest: bpf: Add test for hwtstamp proxy Kuniyuki Iwashima
2026-06-13  1:31   ` Alexei Starovoitov
2026-06-13 22:08     ` Kuniyuki Iwashima
2026-06-13 17:20 ` [PATCH v2 bpf-next/net 0/5] bpf: Support RX/TX HW timestamp proxy Jakub Kicinski
2026-06-13 21:43   ` Kuniyuki Iwashima
2026-06-13 22:47     ` Jakub Kicinski [this message]
2026-06-13 23:18       ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260613154750.0a2355a4@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@google.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=willemb@google.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox